MBL-1029: Refresh Discover page after a user is blocked #1885
Conversation
amy-at-kickstarter
force-pushed
the
feat/adyer/mbl-1029/refresh-on-block
branch
from
6a9d1f8 to
78323ad
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 83.75% 83.75% -0.01%
==========================================
Files 1222 1222
Lines 111393 111429 +36
Branches 29623 29638 +15
==========================================
+ Hits 93299 93323 +24
- Misses 17077 17089 +12
Partials 1017 1017 ☔ View full report in Codecov by Sentry. |
|
|
||
| self.scheduler.advance() | ||
|
|
||
| self.projectsAreLoading.assertValueCount(4) |
There was a problem hiding this comment.
There's a similar test for pullToRefresh that requires this assert to be self.projectsAreLoading.assertValueCount(6). But that seems a bit odd to me (why the extra values)? I'm not sure, then, if this is correct or not.
There was a problem hiding this comment.
I think that might be because there's a loading indicator that shows for pullToRefresh (and I don't think we need to show it here). I could be wrong about that, since I didn't look thoroughly at that code. But test looks good to me!
|
|
||
| self.scheduler.advance() | ||
|
|
||
| self.projectsAreLoading.assertValueCount(4) |
There was a problem hiding this comment.
I think that might be because there's a loading indicator that shows for pullToRefresh (and I don't think we need to show it here). I could be wrong about that, since I didn't look thoroughly at that code. But test looks good to me!
Whoops, good catch! |
📲 What
Once you block a user, anywhere in the app, the Discover page will be refreshed.
🤔 Why
Once you've blocked someone, we want to stop showing that person's content. Refreshing the Discover page means that we'll re-fetch the list of projects, filtering out any projects by blocked users.
⏰ TODO
If I throw in a
logEvent(), it indicates that my signal is hooked up correctly, but I don't think it's actually refreshing the page like I would expect. I could use a little help debugging this behavior to make sure it's working properly.