Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1020] Block Users Feature Flag #1870

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[MBL-1020] Block Users Feature Flag #1870

merged 1 commit into from
Oct 24, 2023

Conversation

scottkicks
Copy link
Contributor

📲 What

A new Feature Flag for the blocking users.

🤔 Why

See engineering plan for more details

🛠 How

  • Updated RemoteConfigFeatures, RemoteConfigFeature+Helpers, RemoteConfigFeatureFlagToolsViewModel.
  • Added tests

block_users was also added to our Firebase RemoteConfig Dashboard Production, Beta and Alpha apps.

👀 See

Screenshot 2023-09-12 at 11 48 35 AM

✅ Acceptance criteria

  • Feature flag is available for use via the featureBlockUsersEnabled() helper method.
  • Feature flag is available in our Firebase RemoteConfig Dashboard
  • Updating the flag from our Firebase dashboard updates the app
  • We can update the app locally. This change persists and takes priority over the Firebase dashboard flag value. This is for internal testing.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1870 (887b6c8) into main (f0bf8e5) will decrease coverage by 0.01%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
- Coverage   83.95%   83.95%   -0.01%     
==========================================
  Files        1222     1222              
  Lines      111055   111082      +27     
  Branches    29506    29522      +16     
==========================================
+ Hits        93241    93263      +22     
- Misses      16801    16805       +4     
- Partials     1013     1014       +1     
Files Coverage Δ
...oteConfigFeatureFlagToolsViewControllerTests.swift 100.00% <100.00%> (ø)
...emoteConfig/RemoteConfigFeature+HelpersTests.swift 100.00% <100.00%> (ø)
...s/RemoteConfigFeatureFlagToolsViewModelTests.swift 100.00% <100.00%> (ø)
...ary/RemoteConfig/RemoteConfigFeature+Helpers.swift 80.00% <80.00%> (ø)
Library/RemoteConfig/RemoteConfigFeature.swift 0.00% <0.00%> (ø)
...Models/RemoteConfigFeatureFlagToolsViewModel.swift 66.29% <62.50%> (-2.85%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks marked this pull request as ready for review October 24, 2023 15:49
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@scottkicks scottkicks merged commit 11adbfc into main Oct 24, 2023
@scottkicks scottkicks deleted the blocking-feature-flag branch October 24, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants