[MBL-970] Report Project Info View #1852

scottkicks · 2023-09-18T17:07:56Z

📲 What

Implement a “Report this project to Kickstarter” button at the bottom of each project page. Clicking this button will open an info view describing the process for reporting projects and when we will/won’t take action displayed in an expandable list.

This view will also include links to a form to report problematic content.

We don't have official designs for this so we're following android's implementation as an example.

🤔 Why

Our iOS app currently violates the User Generated Content Policy in the App Store. Specifically, we need (at the project screen level):

A method for filtering objectionable content
A mechanism for users to flag objectionable content
A mechanism for users to block abusive users

🛠 How

Adds a new "Report this project to Kickstarter" label at the bottom of the overview section of Project pages in ProjectPamphletSubpageCellViewModel (responsible for displaying comments and updates currently)
When tapping this new label, a new SwiftUI View ReportProjectInfoView is pushed onto the nav stack displaying our reporting info in an expandable list.
- Some text includes hyperlinks so, I've added a couple helpers to make it easier to parse the html strings that we need to use here.
- Tapping on an expanded row takes you to a blank view. This will be the submit report form that will be built in the next PR. ticket here

👀 See

TODO

I will wrap this behind the feature flag in the next PR

…ew section

* displays different reporting categories in a nested dropdown style list * some text needs to contain hyperlinks so I added helpers to make this easier.

…arter/ios-oss into report-this-project-views

scottkicks · 2023-09-18T17:58:21Z

Library/ViewModels/ProjectPageViewModel.swift

@@ -99,6 +102,9 @@ public protocol ProjectPageViewModelOutputs {
  /// Emits a `Project` when the updates are to be rendered.
  var goToUpdates: Signal<Project, Never> { get }

+  /// Emits a `Project` when the report project view is to be rendered.
+  var goToReportProject: Signal<Project, Never> { get }


Need to pass a Project here because the submission form will need to include the project url. https://kickstarter.slack.com/files/U0558SFCTL5/F05SJHQP23A/screenshot_20230911-125644.png

So just pass in the project url?

scottkicks · 2023-09-18T17:59:30Z

Kickstarter-iOS/Features/ReportProject/ReportThisProjectListItem.swift

+      type: .parent,
+      title: Strings.Report_spam(),
+      subtitle: Strings
+        .Our(community_guidelines: "https://www.kickstarter.com/help/community?ref=project-page-report"),


Do we have these URLs somewhere in the app already? I wasn't seeing them and I'd rather not hard code these if we can avoid it.

scottkicks · 2023-09-20T14:30:30Z

Library/ViewModels/ProjectPamphletSubpageCellViewModel.swift

@@ -44,15 +44,18 @@ public final class ProjectPamphletSubpageCellViewModel: ProjectPamphletSubpageCe
  public init() {
    let commentsSubpage = self.subpageProperty.signal.skipNil().filter { $0.isComments }
    let updatesSubpage = self.subpageProperty.signal.skipNil().filter { $0.isUpdates }
+    let reportProjectSubpage = self.subpageProperty.signal.skipNil().filter { $0.isReportProject }


Thinking now that I might want to refactor in the next PR where we'll add the "You've already reported this project" label. Rather than add them as a cell to this Pamphlet Subpage Cell, we could add as there own container below it in the tableview. Making it easier to swap between the two and keep this feature entirely SwiftUI.

Think about refactoring this entire cell - entirely in SwiftUI. It looks pretty simple (label - label) setup.
That way we can remove ProjectPamphletSubpageCell entirely. If time constrained no need to do it in this PR.

I agree that this is out of scope for this PR

codecov · 2023-09-20T15:42:25Z

Codecov Report

Merging #1852 (bcdf584) into main (e0657bf) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   84.06%   83.99%   -0.08%     
==========================================
  Files        1280     1283       +3     
  Lines      116823   116986     +163     
  Branches    31043    31111      +68     
==========================================
+ Hits        98207    98258      +51     
- Misses      17532    17641     +109     
- Partials     1084     1087       +3

Files Changed	Coverage Δ
...Features/ReportProject/ReportProjectInfoView.swift	`0.00% <0.00%> (ø)`
KsApi/models/ReportProjectInfoListItem.swift	`0.00% <0.00%> (ø)`
Library/String+Attributed.swift	`65.62% <0.00%> (-34.38%)`	⬇️
Library/SwiftUI+Extensions/Text+HTML.swift	`0.00% <0.00%> (ø)`
...ectPage/Controller/ProjectPageViewController.swift	`50.07% <16.66%> (-0.64%)`	⬇️
...ewModels/ProjectPamphletSubpageCellViewModel.swift	`79.10% <66.66%> (-4.54%)`	⬇️
Library/HelpType.swift	`87.67% <75.00%> (-0.74%)`	⬇️
...tasource/ProjectPageViewControllerDataSource.swift	`83.89% <100.00%> (+0.13%)`	⬆️
...rce/ProjectPageViewControllerDataSourceTests.swift	`97.46% <100.00%> (+0.05%)`	⬆️
Library/ViewModels/ProjectPageViewModel.swift	`97.31% <100.00%> (+0.04%)`	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

msadoon

Good work, I found some things worth addressing but most of the essentials are here.

I found a few notable issues wrt to how this looks and feels:

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-20.at.11.19.31.mp4

Mentioned below but the navigation title and back button should be in one navigation bar. See "Updates" and "Comments" for a consistent user experience.
I noticed in the playground as well, the list view is janky, especially loading that first list of items. I think it might be the way we render the .child objects. Look into fixing it because it is pretty obvious.
Also - you're probably aware but the double back button on the "submit report view" page should be fixed. I think with the 1) fix above, you can get this one too.
Minor - disclosure indicator beside the subpage cell text like in the designs.

Not related to the video

noticed some background color border issues running on iOS 17 for the count values beside "Comments" and "Updates".

msadoon · 2023-09-20T15:11:59Z

Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift

+      self.viewModel.inputs.showNavigationBar(false)
+      self.navigationController?
+        .pushViewController(UIHostingController(rootView: reportProjectInfoView), animated: true)
+    }


I guess we'll be releasing this with the iOS 17 upgrade?

No this is blocking our next release and needs to go out in 5.11.0.

msadoon · 2023-09-20T15:20:14Z

Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift

+  private func goToReportProject(project _: Project) {
+    if #available(iOS 15, *) {
+      let reportProjectInfoView = ReportProjectInfoView()
+      self.viewModel.inputs.showNavigationBar(false)


This might be tied to the weird navigation bar behaviour in the review overview video.

if you look at goToComments and goToUpdates you'll see that we tell the viewmodel to hide the nav bar before pushing those onto the stack. I think this is because the project page is being presented as a sheet. If we don't manually call self.viewModel.inputs.showNavigationBar(false) then the project page navbar (has the x, share, and heart icons) remains on pushed views.

I'll work on getting the new view's nav title to be inline at the top, but I think this is how we need to do this for now.

Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift

msadoon · 2023-09-20T15:22:20Z

...s/test_UKProject_USUser_NonUSLocation.projectLocation_UK_userCurrency_US_userLocation_AU.png

Designs show a disclosure indicator to indicate tappable cell. I don't see one here beside "Report this project to Kickstarter"

I've decided to refactor this label to be it's own swiftUI view to make it easier to toggle between this and the "you've already reported" label in my next PR (MBL-983).

I'll be sure to include a disclosure indicator in that.

msadoon · 2023-09-20T15:35:28Z

Library/ViewModels/ProjectPamphletSubpageCellViewModel.swift

@@ -44,15 +44,18 @@ public final class ProjectPamphletSubpageCellViewModel: ProjectPamphletSubpageCe
  public init() {
    let commentsSubpage = self.subpageProperty.signal.skipNil().filter { $0.isComments }
    let updatesSubpage = self.subpageProperty.signal.skipNil().filter { $0.isUpdates }
+    let reportProjectSubpage = self.subpageProperty.signal.skipNil().filter { $0.isReportProject }


Think about refactoring this entire cell - entirely in SwiftUI. It looks pretty simple (label - label) setup.
That way we can remove ProjectPamphletSubpageCell entirely. If time constrained no need to do it in this PR.

msadoon · 2023-09-20T16:10:08Z

Kickstarter-iOS/Features/ReportProject/ReportProjectInfoView.swift

+  var body: some View {
+    if item.type == .child {
+      // TODO: Push Submission Form View In MBL-971(https://kickstarter.atlassian.net/browse/MBL-971)
+      NavigationLink(destination: { Text("submit report view") }, label: { BaseRowView(item: item) })


Internationlized text for this?

this is just a placeholder for the new view that will actually be pushed

Kickstarter-iOS/Features/ReportProject/ReportThisProjectListItem.swift

msadoon · 2023-09-20T16:14:01Z

Kickstarter-iOS/Features/ReportProject/ReportThisProjectListItem.swift

+      type: .parent,
+      title: Strings.Report_spam(),
+      subtitle: Strings
+        .Our(community_guidelines: "https://www.kickstarter.com/help/community?ref=project-page-report"),


Try to use existing methods of placing urls like HelpType url(withBaseUrl

Recent example use case was the ProjectTabDisclaimerCell

Kickstarter-iOS/Features/ReportProject/ReportThisProjectListItem.swift

Kickstarter-iOS/Features/ReportProject/ReportProjectInfoView.swift

* List view has a bug in iOS 16 that causes expandable rows to have poor animations. My solution uses a ScrollView and a manual Expanded property instead * Also addresses the double navigation bar issues

…arter/ios-oss into report-this-project-views

scottkicks · 2023-09-20T21:40:07Z

@msadoon All of your callouts have been addressed.

re: the janky list view animations. It looks like a bug was introduced in iOS 16.4 that I don't think I can get around by using a List. Instead, I was able to use a ScrollView and a Set object to manually animate a row item's sub views.
It ended up being a pretty simple solution and you'll see that everything animates much more smoothly now!

I also fixed the double navigation bar issue. Since we're using a NavigationController in UIKit to push the view we don't actually need to wrap our SwiftUI view in a NavigationView. We get it for free!

I believe everything else has been covered.

I will re-request your review once CI passes.

…arter/ios-oss into report-this-project-views

ifosli

Overall, I think this looks good. A couple things:

voiceover doesn't work at all. I'm not sure what's going on (haven't done anything with voiceover and swiftui before) but we need to fix that before submitting. I'd be happy to investigate and aim to fix that in a separate pr.
I don't agree with the arrow directions. Arrow down should indicate something that expands down and arrow up should indicate something that can collapse back up. Arrow right should indicate new window. But this is maybe just my opinion and not that important, so I'm okay with the way it is if you like it better and it matches android.

ifosli · 2023-09-21T22:32:10Z

Library/SwiftUI+Extensions/Text+HTML.swift

+  @available(iOS 15, *)
+  init(html: String, with hyperlink: String) {
+    do {
+      var attrString = try html.htmlToAttributedString()


I agree with Mubarak here - as we gradually update our app to swiftui, I'd personally prefer not to move files around while we do so.

scottkicks · 2023-09-21T23:29:57Z

@ifosli I forgot to test voiceover. It would definitely be helpful if you took a look at that.

Feeling a bit rushed with this since code freeze is next week. We still need to build the view that allows users to submit reports as well as the "You've already reported" label (working in that now). Anything you can pick up would be helpful.

As for the arrow icons, I see your point. I was trying to follow androids design as closely as possible. Without official designs tho, I think it's something we can address after the release is unblocked. Thoughts?

scottkicks added 7 commits September 13, 2023 13:09

add new "Report This Project" row to Project overviewSubpages tablevi…

d3b513e

…ew section

navigate to ReportThisProjectInfoView

c46c8d9

formatting

a23f0ed

create ReportProjectInfoView

42c426b

* displays different reporting categories in a nested dropdown style list * some text needs to contain hyperlinks so I added helpers to make this easier.

create ReportProjectInfoView

36f854d

* displays different reporting categories in a nested dropdown style list * some text needs to contain hyperlinks so I added helpers to make this easier.

formatting and cleanup

c2b7914

Merge branch 'report-this-project-views' of https://github.com/kickst…

11e5563

…arter/ios-oss into report-this-project-views

scottkicks self-assigned this Sep 18, 2023

scottkicks added the draft label Sep 18, 2023

scottkicks added this to the release-5.11.0 milestone Sep 18, 2023

scottkicks added 3 commits September 18, 2023 11:11

Merge branch 'main' into report-this-project-views

dcfc84e

make Text extension more generic

0d4b397

Merge branch 'report-this-project-views' of https://github.com/kickst…

73cc7a9

…arter/ios-oss into report-this-project-views

scottkicks commented Sep 18, 2023

View reviewed changes

tests

63adaba

scottkicks force-pushed the report-this-project-views branch from 5e3cb44 to 63adaba Compare September 18, 2023 19:10

kickstarter deleted a comment from nativeksr Sep 18, 2023

formatting

9596a13

scottkicks marked this pull request as ready for review September 18, 2023 20:30

scottkicks requested review from msadoon and ifosli September 18, 2023 20:31

scottkicks added needs review and removed draft labels Sep 18, 2023

scottkicks commented Sep 20, 2023

View reviewed changes

add goToReportProject output test

17b3898

kickstarter deleted a comment from nativeksr Sep 20, 2023

scottkicks added 2 commits September 20, 2023 09:47

format

be5c703

Merge branch 'main' into report-this-project-views

3a804c6

kickstarter deleted a comment from codecov bot Sep 20, 2023

msadoon suggested changes Sep 20, 2023

View reviewed changes

scottkicks added 6 commits September 20, 2023 14:28

only pass project url to ReportProjectInfoView

806c95d

revert .pbxproj change

d4a7de4

move model into KsApi target and replace hardcoded strings

7daee5a

refactor List view

020ee58

* List view has a bug in iOS 16 that causes expandable rows to have poor animations. My solution uses a ScrollView and a manual Expanded property instead * Also addresses the double navigation bar issues

Merge branch 'report-this-project-views' of https://github.com/kickst…

256e33a

…arter/ios-oss into report-this-project-views

Merge branch 'main' into report-this-project-views

07f8d0e

scottkicks added 2 commits September 20, 2023 17:11

formatting

0548b41

Merge branch 'report-this-project-views' of https://github.com/kickst…

bcdf584

…arter/ios-oss into report-this-project-views

scottkicks requested a review from msadoon September 21, 2023 14:05

ifosli approved these changes Sep 21, 2023

View reviewed changes

scottkicks merged commit ae5ef71 into main Sep 23, 2023

scottkicks deleted the report-this-project-views branch September 23, 2023 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-970] Report Project Info View #1852

[MBL-970] Report Project Info View #1852

scottkicks commented Sep 18, 2023 •

edited

Loading

scottkicks Sep 18, 2023

msadoon Sep 20, 2023

scottkicks Sep 18, 2023

scottkicks Sep 20, 2023

msadoon Sep 20, 2023 •

edited

Loading

scottkicks Sep 20, 2023

codecov bot commented Sep 20, 2023 •

edited

Loading

msadoon left a comment •

edited

Loading

msadoon Sep 20, 2023

scottkicks Sep 20, 2023

msadoon Sep 20, 2023

scottkicks Sep 20, 2023

msadoon Sep 20, 2023

scottkicks Sep 20, 2023

msadoon Sep 20, 2023 •

edited

Loading

msadoon Sep 20, 2023

scottkicks Sep 20, 2023

msadoon Sep 20, 2023

msadoon Sep 20, 2023

scottkicks commented Sep 20, 2023 •

edited

Loading

ifosli left a comment

ifosli Sep 21, 2023

scottkicks commented Sep 21, 2023

[MBL-970] Report Project Info View #1852

[MBL-970] Report Project Info View #1852

Conversation

scottkicks commented Sep 18, 2023 • edited Loading

📲 What

🤔 Why

🛠 How

👀 See

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msadoon Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 20, 2023 • edited Loading

Codecov Report

msadoon left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msadoon Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks commented Sep 20, 2023 • edited Loading

ifosli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks commented Sep 21, 2023

scottkicks commented Sep 18, 2023 •

edited

Loading

msadoon Sep 20, 2023 •

edited

Loading

codecov bot commented Sep 20, 2023 •

edited

Loading

msadoon left a comment •

edited

Loading

msadoon Sep 20, 2023 •

edited

Loading

scottkicks commented Sep 20, 2023 •

edited

Loading