-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-952] Design System Demo Page (Dark Mode) #1849
Conversation
…ller updates BetaToolsViewController Snapshot as well
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 84.59% 84.06% -0.54%
==========================================
Files 1276 1280 +4
Lines 116017 116769 +752
Branches 30888 31019 +131
==========================================
+ Hits 98149 98162 +13
- Misses 16786 17525 +739
Partials 1082 1082
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm thinking of adding in all of the colors that we got from design that includes new light and dark mode colors and organizing them similarly to how Android has done it here. Keeping the existing colors and naming, but setting ourselves up to easily apply the newer ones. |
2d0d0aa
to
e27a358
Compare
I think we should add icons - I definitely think the kickstarter logo needs to be represented here (both because it feels important and because I didn't see anything else with that color). The logo is an icon, so if we're adding that, we might as well add one of our gray icons as well. Icons are just a UIImage with the tint color set. I'm not sure where we store these image assets but I'd be happy to help you look into it if you'd like. Apart from that, I like the variety of components! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort, some improvements can be made here.
I think it's still very demo'able.
I would say - if I did this, I wouldn't depend too much on a storyboard and purely have the in-app components in a programmatic SystemDesignViewController
.
High level that would be copy paste the in-app component in the SystemDesignViewController
without any layers in between. That kind of simplifies things in terms of updating the components later.
Feel free to reach out and discuss specifics/or if I can provide any clarity - let me know!
Kickstarter.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Kickstarter-iOS/Features/MessageBanner/Storyboard/MessageBannerViewController.xib
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgeView/Views/PledgeViewCTAContainerView.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/SystemDesign/Views/DemoShimmerLoadingView.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/SystemDesign/Colors/SystemDesignColors.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/SystemDesign/Colors/SystemDesignColors.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/SystemDesign/Colors/SystemDesignColors.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/SystemDesign/Colors/SystemDesignColors.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading your comments here @scottkicks I'll leave this with you. Try to make sure the colours are as accurate as possible with the system design doc or the existing colours in-app. (You may already be doing this, just thought I'd point it out.)
…team these are in a draft, but are close to be finalized at least for the web
db68f3e
to
a227b23
Compare
@ifosli added a few icons :) |
4c1c5e8
to
dfaea23
Compare
📲 What
Extending our current debug menu to include a System Design page.
This screen will essentially be a copy/past (styling-wise) of all views/components listed in our current design system.
Used our existing design system as a reference. This is very incomplete so I did my best to capture all existing components other than icons.
If there is anything missing you'd like to see added, call it out!
🤔 Why
This came about as we considered the best approach for implementing Dark Mode.
This approach lets us move the existing components from our app/design system to the demo page first. From there it should be easy to update any one component to SwiftUI, Dark Mode, etc.
🛠 How
Added a new page to DesignSystemViewController to our Beta Tools VC. New snapshots were added for this new row as well.
It will look like duplicated code for now but this way, we can make changes here (adding new colors, components, and designs) w/o impacting the rest of the app.
I added our current color scheme to Xcode.assets with temporary dark mode color versions. Once we have proper Dark Mode designs it'll be easy to update and test these.
Focusing on colors for now since fonts will be much more complex and include dynamic view sizing.
👀 See
✅ Acceptance criteria
Make sure to remove the "Appearance" override in the info.plist. Otherwise, you won't see the dark mode color change.
⏰ TODO