-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-897] Feature Flag Use of AI Project Tab #1841
Conversation
corrections to helper tests
Codecov Report
@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 1274 1274
Lines 115216 115279 +63
Branches 30666 30698 +32
=======================================
+ Hits 97402 97456 +54
- Misses 16746 16754 +8
- Partials 1068 1069 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is GraphAPI
being updated 🤔? This mutation should have been updated when I cleaned up this mutation in my TriggerThirdPartyEvent implementation.
We need this update, but it would be better to address this in its own PR and keep the context of this one to the feature flag
func testCreatorDashboard_RemoteConfig_FeatureFlag_True() { | ||
let mockRemoteConfigClient = MockRemoteConfigClient() | ||
|> \.features .~ [RemoteConfigFeature.creatorDashboardEnabled.rawValue: true] | ||
|
||
withEnvironment(remoteConfigClient: mockRemoteConfigClient) { | ||
XCTAssertTrue(featureCreatorDashboardEnabled()) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also should update the feature flag view controller's snapshot tests
Good point, normally it would be better to have this as a separate change elsewhere, but it's a change that happens as part of the build process. I mentioned in this comment, every time the project gets built that GraphAPI file updates based on the With a cursory glance, it looks like the backend folks cleaned up the Another alternative is to remove the changes here for |
Co-authored-by: Scott Clampet <110618242+scottkicks@users.noreply.github.com>
Co-authored-by: Scott Clampet <110618242+scottkicks@users.noreply.github.com>
Yes! Missed this, good catch. |
…/kickstarter/ios-oss into mbl-897/ff-use-of-ai-project-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just need to update with main
📲 What
Part of the new project page "Use of AI" tab.
🤔 Why
Feature flag is standard for launching new feature.
🛠 How
Added to
RemoteConfigFeatures
,RemoteConfigFeature+Helpers
,RemoteConfigFeatureFlagToolsViewModel
.use_of_ai_project_tab
also added to RemoteConfig on Firebase Remote Config. Productio, Beta and Alpha.👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria