[No Ticket] Update Localized Strings #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a draft pr for now while waiting on the translations for this new string. |
scottkicks
added
blocked
scottkicks
force-pushed
the
scott/update-strings
branch
from
58784c1 to
32c1439
Compare
scottkicks
added
needs review
and removed
blocked
|
This is now ready to be reviewed once the GraphSchema has been updated an all CI tests pass |
Codecov Report
@@ Coverage Diff @@
## main #1831 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 1276 1276
Lines 115816 115816
Branches 30793 30793
=======================================
Hits 97716 97716
Misses 17034 17034
Partials 1066 1066 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Copy for the dashboard removal warning banner was recently added to the Kickstarter repo.
This pulls in those updates.
Important Note
A string was added by the android team since they are displaying a banner too. The actual copy though is slightly different than the one we need for iOS.
They are similar and it may look like duplicate code, but that is why.
For reference, the
Creator_dashboard_removal_warningkey is what we need.🤔 Why
We need to make sure we're using localized strings and their translations.
🛠 How
After the string has been added to the Kickstarter repo all we need to do is run
make stringsto manually to update our strings from the server✅ Acceptance criteria