-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-330] Page Viewed (log_in) #1451
Conversation
Add a test for the login page viewed tracking method.
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 1109 1109
Lines 98939 98963 +24
=======================================
+ Hits 85212 85235 +23
- Misses 13727 13728 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small comment.
segmentClient: segmentClient | ||
) | ||
|
||
ksrAnalytics.trackLoginPageViewed() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this test into the function defined on line 2442 of this file? It looks like we add/test all the events into there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
π² What
π€ Why
This is part of phase 6 Segment event project.
π See
β Acceptance criteria