Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-330] Page Viewed (log_in) #1451

Merged
merged 4 commits into from
Apr 29, 2021
Merged

[EP-330] Page Viewed (log_in) #1451

merged 4 commits into from
Apr 29, 2021

Conversation

tobitech
Copy link
Contributor

πŸ“² What

  • Add a page viewed event tracking method for login page.
  • Add a test for the login page viewed tracking method.

πŸ€” Why

This is part of phase 6 Segment event project.

πŸ‘€ See

Screenshot 2021-04-28 at 17 00 34

βœ… Acceptance criteria

  1. Launch the App and navigate to Login screen, that's if you're not already logged in.
  2. Verify that a Page Viewed event shows up in Segment debugger with these properties
"event": "Page Viewed"
"context_page": "log_in"

Add a test for the login page viewed tracking method.
@tobitech tobitech requested review from singhhari and moderateepheezy and removed request for singhhari and moderateepheezy April 28, 2021 20:16
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1451 (94a326e) into master (55a3c1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1451   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files        1109     1109           
  Lines       98939    98963   +24     
=======================================
+ Hits        85212    85235   +23     
- Misses      13727    13728    +1     
Impacted Files Coverage Ξ”
Library/Tracking/KSRAnalytics.swift 85.87% <100.00%> (+0.04%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ΓΈ)
Library/ViewModels/LoginViewModel.swift 97.70% <100.00%> (+0.08%) ⬆️
Library/ViewModels/LoginViewModelTests.swift 100.00% <100.00%> (ΓΈ)
Library/Navigation.swift 76.89% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 55a3c1d...94a326e. Read the comment docs.

@singhhari singhhari self-assigned this Apr 29, 2021
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment.

segmentClient: segmentClient
)

ksrAnalytics.trackLoginPageViewed()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this test into the function defined on line 2442 of this file? It looks like we add/test all the events into there.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobitech tobitech merged commit 45be52b into master Apr 29, 2021
@tobitech tobitech deleted the EP-330-page-viewed-log-in branch April 29, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants