[Ep-458] QA Page Viewed (Project) Phase 1 #1424
Conversation
…scriptionViewModel Include RefTag as part of configuration data for ProjectDescriptionViewController
Provide a helper test method to compare tuple values of ProjectPamphletMainCellData
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
=======================================
Coverage 86.08% 86.09%
=======================================
Files 1106 1106
Lines 98101 98096 -5
=======================================
+ Hits 84453 84455 +2
+ Misses 13648 13641 -7
Continue to review full report at Codecov.
|
…ned from faqs url
| @@ -642,6 +642,16 @@ final class AppDelegateViewModelTests: TestCase { | |||
| XCTAssertTrue(result) | |||
|
|
|||
| self.presentViewController.assertValues([1, 2, 2, 2, 3]) | |||
|
|
|||
| let faqUrl = projectUrl + "/faqs" | |||
There was a problem hiding this comment.
Are these tests unrelated to the ticket?
There was a problem hiding this comment.
Yes it's unrelated.
| [nil] | ||
| ) | ||
| } | ||
| private func assertProjectRefTagEqual( |
There was a problem hiding this comment.
Can this be replaced with a standard assertion like we use everywhere else?
There was a problem hiding this comment.
XCTAssertEqual doesn't work with tuples because they don't conform to Equatable protocol that's why I had to do that. Another option would be to pass the Project and RefTag as separate parameters to the config() method of ProjectDescriptionViewController
📲 What
Page viewed for project was tracked in two places.
Moved the one for campaign section context into Project Description screen when the content loads.
Add RefTag as part of the Config Data sent to ProjectDescription screen.
🤔 Why
This is part of phase 1 Events QA.
👀 See