[EP-404] QA Phase 1 Fix User Properties #1417
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.02%
==========================================
Files 1106 1106
Lines 97930 97964 +34
==========================================
+ Hits 84327 84340 +13
- Misses 13603 13624 +21
Continue to review full report at Codecov.
|
Library/Tracking/KSRAnalytics.swift
Outdated
| props["is_admin"] = user?.isAdmin | ||
| props["launched_projects_count"] = user?.stats.memberProjectsCount | ||
| props["launched_projects_count"] = user?.stats.createdProjectsCount |
There was a problem hiding this comment.
Same here. I think it would be very useful to have all this info documented somewhere so we have a reference in the future.
…ckstarter/ios-oss into EP-404-qa-phase-1-fix-user-properties
Library/Tracking/KSRAnalytics.swift
Outdated
| props["created_projects_count"] = (user?.stats.createdProjectsCount ?? 0) + | ||
| (user?.stats | ||
| .draftProjectsCount ?? | ||
| 0) // Stats.createdProjectsCount is the count of projects user has lauched only, while event property `created_projects_count` includes Stats.createdProject + Stats.draftProjectsCount |
There was a problem hiding this comment.
typos and still unclear. move this above line 1813 with the following description:
the product/insights team definition of created_projects_count is the sum of createdProjectsCount and draftProjectsCount
Library/Tracking/KSRAnalytics.swift
Outdated
| props["is_admin"] = user?.isAdmin | ||
| props["launched_projects_count"] = user?.stats.memberProjectsCount | ||
| props["launched_projects_count"] = user?.stats | ||
| .createdProjectsCount // event property`launched_projects_count` = Stats.createdProjectsCount |
There was a problem hiding this comment.
change to:
product and insights defines launched_projects_count as only the createdProjectsCount
📲 What
Change how we send
launched_project_countandcreated_project_countfor User Properties to Segment.🤔 Why
The api returns created_project_count, this is the count of the project that you've created, but on segment user_created_project_count definition is different, to get the value you'll need created_project_count from api + draft_project_count from the api, while
launched_project_counton segment iscreated_project_countfrom the api.