[EP-401] Fix properties (phase one)

[singhhari]

📲 What

Fixing properties after phase one of Segment QA. Some of these are smaller changes like changing the type whereas some are updates to where we get the values from.

🤔 Why

Updates after receiving QA feedback for phase one of our Segment implementation.

[codecov]

Codecov Report

Merging #1414 (f1092e2) into master (1de00c5) will increase coverage by 0.01%.
The diff coverage is 95.76%.

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   86.10%   86.11%   +0.01%     
==========================================
  Files        1106     1106              
  Lines       97850    97950     +100     
==========================================
+ Hits        84251    84347      +96     
- Misses      13599    13603       +4     

Impacted Files	Coverage Δ
KsApi/models/PaymentType.swift	0.00% <0.00%> (ø)
Library/UIDeviceType.swift	62.50% <ø> (ø)
Library/SharedFunctions.swift	89.05% <100.00%> (ø)
Library/SharedFunctionsTests.swift	100.00% <100.00%> (ø)
Library/Tracking/KSRAnalytics.swift	85.32% <100.00%> (+0.53%)	⬆️
Library/Tracking/KSRAnalyticsTests.swift	100.00% <100.00%> (ø)
Library/ViewModels/LoginToutViewModelTests.swift	100.00% <100.00%> (ø)
Library/ViewModels/PledgeViewModelTests.swift	100.00% <100.00%> (ø)
...ary/ViewModels/ProjectPamphletViewModelTests.swift	100.00% <100.00%> (ø)
Library/ViewModels/ThanksViewModelTests.swift	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de00c5...f1092e2. Read the comment docs.