-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-283] CTA Clicked (campaign details) #1409
Conversation
* Write a test to check properties sent to segment for that event.
… when a button is clicked
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
=======================================
Coverage 86.09% 86.09%
=======================================
Files 1104 1104
Lines 97806 97804 -2
=======================================
- Hits 84206 84205 -1
+ Misses 13600 13599 -1
Continue to review full report at Codecov.
|
* Add page context to the same event method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions related to the changes but also need to bump coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📲 What
Send a CTA clicked event when the "Read more about the campaign" is clicked to view campaign details
🤔 Why
Part of phase 3 iOS Native events tracking