Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-364] Adding project_tags #1402

Merged
merged 5 commits into from
Mar 22, 2021
Merged

Conversation

singhhari
Copy link
Contributor

📲 What

Decoding tags from the API request for a given project and sending that with our existing project properties, to Segment.

🤔 Why

Phase 2 segment implementation

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1402 (aea0218) into master (48f5f80) will decrease coverage by 0.00%.
The diff coverage is 66.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   86.02%   86.02%   -0.01%     
==========================================
  Files        1104     1104              
  Lines       97243    97296      +53     
==========================================
+ Hits        83658    83701      +43     
- Misses      13585    13595      +10     
Impacted Files Coverage Δ
KsApi/models/lenses/ProjectLenses.swift 17.37% <30.00%> (+2.31%) ⬆️
KsApi/models/Project.swift 70.33% <100.00%> (+0.25%) ⬆️
KsApi/models/ProjectTests.swift 100.00% <100.00%> (ø)
Library/Tracking/KSRAnalytics.swift 83.75% <100.00%> (+0.02%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
Library/Navigation.swift 77.25% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f5f80...aea0218. Read the comment docs.

@singhhari singhhari merged commit c5aa991 into master Mar 22, 2021
@singhhari singhhari deleted the EP-364-create-project-tag-property branch March 22, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants