-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-256] Card Clicked #1400
[EP-256] Card Clicked #1400
Conversation
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
+ Coverage 85.99% 86.03% +0.03%
==========================================
Files 1104 1104
Lines 97025 97243 +218
==========================================
+ Hits 83441 83659 +218
Misses 13584 13584
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
account_menu
does not have a test in testLocationContextTrackingStrings
. However, you can skip that because I as-well defined account_menu
in my branch, and include the tests for it. It's going to cause conflict on my branch, but that I can resolve.
Updated and added a few more checks for it elsewhere. |
📲 What
Updating existing
Editorial Page Header Clicked
andProject Card Clicked
events toCard Clicked
. Also adding this event into some new places like ourThanksViewModel
,SearchViewModel
and within the backed/saved Profile tab.🤔 Why
Segment phase two