Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1760] Adding feature flag for segment #1376

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

singhhari
Copy link
Contributor

📲 What

Adding a feature flag for Segment and implementing it within out Analytics client.

🤔 Why

This is simply an additional layer of control on the clients behavior in our environments.

🛠 How

  • Added the flag on Flipper
  • Decoding it on iOS
  • Implementing it into the Segment client

Copy link
Contributor

@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Hari!

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #1376 (c670788) into master (056e871) will decrease coverage by 3.41%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
- Coverage   89.27%   85.85%   -3.42%     
==========================================
  Files         734     1103     +369     
  Lines       66260    96079   +29819     
==========================================
+ Hits        59152    82489   +23337     
- Misses       7108    13590    +6482     
Impacted Files Coverage Δ
Library/Feature.swift 0.00% <0.00%> (ø)
Library/Tracking/Segment.swift 73.91% <66.66%> (-1.09%) ⬇️
Library/Extensions/Feature+Helpers.swift 100.00% <100.00%> (ø)
Library/Extensions/Feature+HelpersTests.swift 100.00% <100.00%> (ø)
...ry/ViewModels/FeatureFlagToolsViewModelTests.swift 100.00% <100.00%> (ø)
Library/Tracking/MockTrackingClient.swift 90.47% <0.00%> (-9.53%) ⬇️
...ollers/ShippingRulesTableViewControllerTests.swift 100.00% <0.00%> (ø)
... and 371 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056e871...2d921fc. Read the comment docs.

@singhhari singhhari merged commit 5fdbf1c into master Feb 22, 2021
@singhhari singhhari deleted the NT-1760-segment-feature-flag branch February 22, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants