[NT-167] Update constraints for alert banner landscape support #1359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The alert banner we present is currently constrained in such a way that, on landscape, the notch present on newer iPhone models is obstructing some of the view. The view controller that handles this alert banner is supported with a
xib
which requires some updates to the leading and trailing constraints.🤔 Why
iOS allows developers to constraint views to a safe area, which was a useful way to avoid interactions with the extreme edges of the phone. It appears the implementation for our portrait support was fine but landscape had some minor issues.
🛠 How
Updated the xib file handling the alert banner to constraint leading and trailing to the safe area.
👀 See