Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-167] Update constraints for alert banner landscape support #1359

Merged

Conversation

singhhari
Copy link
Contributor

📲 What

The alert banner we present is currently constrained in such a way that, on landscape, the notch present on newer iPhone models is obstructing some of the view. The view controller that handles this alert banner is supported with a xib which requires some updates to the leading and trailing constraints.

🤔 Why

iOS allows developers to constraint views to a safe area, which was a useful way to avoid interactions with the extreme edges of the phone. It appears the implementation for our portrait support was fine but landscape had some minor issues.

🛠 How

Updated the xib file handling the alert banner to constraint leading and trailing to the safe area.

👀 See

Simulator Screen Shot - iPhone 12 - 2020-12-21 at 14 13 00
Simulator Screen Shot - iPhone 12 - 2020-12-21 at 14 13 22

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1359 (e5981ac) into master (77cca6c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   86.05%   86.05%   -0.01%     
==========================================
  Files        1099     1099              
  Lines       97628    97628              
==========================================
- Hits        84012    84011       -1     
- Misses      13616    13617       +1     
Impacted Files Coverage Δ
Library/Navigation.swift 76.89% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cca6c...e5981ac. Read the comment docs.

@singhhari singhhari merged commit ef9a2a9 into master Jan 4, 2021
@singhhari singhhari deleted the NT-167-alert-banner-constraints-update-on-landscape branch January 4, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants