-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-1586] Fix shipping costs on Add On selection #1321
Conversation
…ering on the query
…he entire view model is using the same one.
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
+ Coverage 85.77% 85.78% +0.01%
==========================================
Files 1109 1109
Lines 97337 97474 +137
==========================================
+ Hits 83492 83620 +128
- Misses 13845 13854 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what exactly the difference between ShippingRules
and ShippingRulesExpanded
. What do we miss in ShippingRules
?
Also can you please add some Acceptance Criteria and steps to reproduce the issue. |
@andrewKstrt |
📲 What
After selecting a reward and being directed to the add on selection screen, incorrect shipping costs were being shown. We determined the issue was caused by the wrong field being fetched and used in our GraphQL query. This PR updates the query to utilize
shippingRulesExpanded
and updates existing schema to decodeshippingRulesExpanded
for use.🤔 Why
Some creators noted the shipping costs were being calculated incorrectly on the pledge screen which suggested an issue with the way we were using shipping rules. After taking a look it appeared that were using the wrong set of shipping rules being returned from our query.
🛠 How
Made some updates to the relevant query by adding a parameter for location id, This was necessary, otherwise we would be pulling hundreds of shipping locations per add on. Moreover, we're decoding our new field and using it for filtering add ons.
✅ Acceptance criteria
Steps to test this feature:
dungeon-drop-dropped-too-deep-and-tavern-tales
(or any project that has international shipping on production)Game Bundle
in the case of the example above.Limited Promo Pack (2020) mini-expansion
($0 shipping) and pay attention to the price the creator has set for shipping.Limited Promo Pack (2020) mini-expansion
.Expected: shipping cost should be $0 (based on what the creator set)