do not re-render embeddable so often (elastic#95653) (elastic#95812)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
kibanamachine · Mar 30, 2021 · f39f67a · f39f67a
1 parent 0f488c4
commit f39f67a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.test.tsx b/x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.test.tsx
@@ -338,7 +338,13 @@ describe('embeddable', () => {
     expect(expressionRenderer).toHaveBeenCalledTimes(2);
   });
 
-  it('should re-render when dashboard view/edit mode changes', async () => {
+  it('should re-render when dashboard view/edit mode changes if dynamic actions are set', async () => {
+    const sampleInput = ({
+      id: '123',
+      enhancements: {
+        dynamicActions: {},
+      },
+    } as unknown) as LensEmbeddableInput;
     const embeddable = new Embeddable(
       {
         timefilter: dataPluginMock.createSetupContract().query.timefilter.timefilter,
@@ -371,6 +377,13 @@ describe('embeddable', () => {
       viewMode: ViewMode.VIEW,
     });
 
+    expect(expressionRenderer).toHaveBeenCalledTimes(1);
+
+    embeddable.updateInput({
+      ...sampleInput,
+      viewMode: ViewMode.VIEW,
+    });
+
     expect(expressionRenderer).toHaveBeenCalledTimes(2);
   });
 

diff --git a/x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.tsx b/x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.tsx
@@ -172,7 +172,10 @@ export class Embeddable
           skip(1)
         )
         .subscribe((input) => {
-          this.reload();
+          // only reload if drilldowns are set
+          if (this.getInput().enhancements?.dynamicActions) {
+            this.reload();
+          }
         })
     );