-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made QoL adjustments and file cleanup #159
Open
brimdor
wants to merge
3
commits into
khuedoan:master
Choose a base branch
from
pixelpaladins:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimdor
commented
May 10, 2024
- replaced specific unique items with placeholders (ex. khuedoan.com is now )
- added a placeholder for control plane endpoint
- added reset script
- added cronjobs
- added nfs_utils
- adjusted the configure script to utilize placeholders
- added a branch option in case someone wants to use a different branch than master
- removed old configure and added new configure script
- replaced specific unique items with placeholders - added reset script - added cronjobs - added nfs_utils - adjusted the configure script to utilize placeholders - added a branch option in case someone wants to use a different branch than master
renamed new file to "configure" and removed old configure file
- adjusted tools in Makefile to add the safe.directory argument to the docker run command in order to fix the error regarding ownership (Refer to khuedoan#139)
Hi, thank you for making a PR. However, it seems like this should be split into multiple PRs to make it more reviewable and reduce the blast radius. Although these changes are unlikely to be merged for the following reasons:
|
Thanks for the info. It sounds like I didn't understand the primary purpose
and use case of your homelab. No problem.
…On Mon, May 13, 2024, 05:31 Khue Doan ***@***.***> wrote:
Hi, thank you for making a PR. However, it seems like this should be split
into multiple PRs to make it more reviewable and reduce the blast radius.
Although these changes are unlikely to be merged for the following reasons:
- Placeholders: Using khuedoan.com is intentional. This project is
meant to be applied directly in *my homelab*, with a script to make it
more convenient to adapt to your homelab. It's not meant to be a template
repo.
- Reset script: This is unnecessary since the nodes are designed to be
cattle, not pets. To reset them, you can simply turn them off and run
make to rebuild.
- Cronjobs: Shouldn't this already be covered by the automatic upgrade?
- nfs_utils: I'm assuming this is for RWX volumes, does the
standard-rwx storage class suffice? (It was added as part of the Ceph
migration)
- Branch option: I don't plan to change my default branch, and it will
complicate the installation instructions (e.g., "if you want to change the
branch, you have to fork, checkout a new branch, change the default branch
in GitHub, change this and this, etc."). It unnecessarily increases
friction without any benefit.
—
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJFVDYE3JQUTVDHFH4LMW3ZCCI7RAVCNFSM6AAAAABHQULJEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGIYTONBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.