Add ACME certificate generation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a little extra work to tie the websocket implementation together. Things are slightly complicated due to multiple versions of rustls being involved between fabruic and this acme implementation. This doesn't have certificate renewal in it, and it needs to be cleaned up a lot.
The certificates still need to be stored in the database, but I want to ponder a little while longer before tackling that part -- I think the Server should have its own Admin database, as the "local" database has no need to know about domains and Acme.
Now that the caching process works directly with Bonsai's certificate storage, we can use the built-in order function -- greatly reducing the complexity.
Hopefully all of them.
I implemented this because of a todo in PR #95. However, after implementing it, I realized that the todo was outdated -- I was no longer taking a der-encded private key and wrapping it in a pem before calling this function. I needed to in an older implementation of the manually-driven acme loop, but since moving to the built-in `order` function it was no longer needed. However, it seems like a perfectly fine idea to keep in place, so I've done that.
Both of these additions are to try to reduce some of the tedium I've been encountering in day-to-day usage.
TlsCertificates are a little bit more future-proofed, although currently install_certificate just assumes the certificate matches the `server_name`. This also finished removing some of the holdover fabruic-only "server name" functionality from pinned certificates. Everything is unified through this setting.
This was referenced Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.
Remaining tasks:
write up a task to do it built upon Implement persistent job queue and scheduling service #78.