Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Invalid Json generated #60

Closed
energise opened this issue May 8, 2021 · 1 comment
Closed

Invalid Json generated #60

energise opened this issue May 8, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@energise
Copy link

energise commented May 8, 2021

Describe the bug

Hi! I was looking to use the json interface but found that some of the json that ESP_WifiManager outputs is invalid.

Eg - it outputs on /scan:

{"Access_Points":[{'SSID':'UPC434892', 'Encryption':true, 'Quality':'98'}, {'SSID':'Horizon Wi-Free', 'Encryption':true, 'Quality':'66'}, {'SSID':'vodafone-602D', 'Encryption':true, 'Quality':'32'}]}

This is great except that single quotes aren't allowed in json - only double quotes

https://findanyanswer.com/does-json-allow-single-quotes

Steps to Reproduce

http://192.168.4.1/scan

Expected behavior

valid json returned

Actual behavior

invalid json returned

Debug and AT-command log (if applicable)

Screenshots

image

image

Information

Please ensure to specify the following:

ESP8266
Arduino 1.8.13

Thanks for such an amazing library

khoih-prog added a commit that referenced this issue May 8, 2021
### Releases v1.7.1

1. Fix Json bug in /scan. Check [Invalid Json generated #60](#60)
2. Fix timezoneName not displayed in Info page.
khoih-prog added a commit that referenced this issue May 8, 2021
### Releases v1.7.1

1. Fix Json bug in /scan. Check [Invalid Json generated #60](#60)
2. Fix timezoneName not displayed in Info page.
khoih-prog added a commit that referenced this issue May 8, 2021
### Releases v1.7.1

1. Fix Json bug in /scan. Check [Invalid Json generated #60](#60)
2. Fix timezoneName not displayed in Info page.
@khoih-prog
Copy link
Owner

Hi @energise

Thanks for your bug report and your encouraging words. The new ESP_WiFiManager release v1.7.1 has just been published, with your Contribution noted in Contributions and Thanks.

Looking forward to receiving more Contributions of yours.

Regards,


Releases v1.7.1

  1. Fix Json bug in /scan. Check Invalid Json generated #60
  2. Fix timezoneName not displayed in Info page.

@khoih-prog khoih-prog added the bug Something isn't working label May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants