This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Fix file upload handler by adjusting function signatures #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Merging now and new release published soon. |
|
Hi @edwinvp Please check the new release AsyncWebServer_Teensy41 v1.7.0 Your contribution is noted in Contributions and Thanks Releases v1.7.0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch intends to fix the file upload feature of the async web server.
As seen icw with the Teensy 4.1 board.
When one uploads a file through the web server the appropriate handlers aren't called.
Or perhaps only the default implementation of the virtual method is called which does nothing.
This PR changes the signatures of the file upload handler methods in an attempt to fix that.
The fix was originally proposed by member Shuptuu of the PJRC forum:
https://forum.pjrc.com/index.php?threads/asyncwebserver_teensy41-bug-onupload.72220