Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Remove unavailable items from depends field of library.properties #35

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Remove unavailable items from depends field of library.properties #35

merged 1 commit into from
Aug 10, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 10, 2022

The depends field of the library.properties metadata file specifies the dependencies that should be installed along with
the library by the Arduino Library Manager.

This field must contain only the names of libraries that are available for installation via Library Manager.

The presence of any items which are not in Library Manager causes installation of the library to fail:

Originally reported at https://forum.arduino.cc/t/arduino-sdk-error-trying-to-download-library/967231

Related

The depends field of the library.properties metadata file specifies the dependencies that should be installed along with
the library by the Arduino Library Manager.

This field must contain only the names of libraries that are available for installation via Library Manager.

The presence of any items which are not in Library Manager causes installation of the library to fail:

- Arduino IDE 1.x: "no protocol:" error
- Arduino IDE 2.x: fails silently
- Arduino CLI: "No valid dependencies solution found" error
@khoih-prog khoih-prog merged commit f420987 into khoih-prog:master Aug 10, 2022
@khoih-prog
Copy link
Owner

Hi @per1234

Thanks for the PR. We've been waiting and expecting those libraries to be added to Arduino Library Manager quite a long time.

Can someone help by forking them, then adding to Library Manager. Or Arduino Library Manager can be modified to add any library, by specifying git location, similar to library.json

{
"name": "STM32AsyncTCP",
"version": "https://github.com/khoih-prog/STM32AsyncTCP"
}

Anyway, I'm merging the PR now to avoid issues.

@per1234
Copy link
Contributor Author

per1234 commented Aug 10, 2022

We've been waiting and expecting those libraries to be added to Arduino Library Manager quite a long time.

Yeah, it is really unfortunate that they aren't available via Library Manager since they are dependencies of many libraries.

Can someone help by forking them, then adding to Library Manager.

I think that is the best solution. The requests go back years without any response except for a bot closing them unjustly.

Arduino Library Manager can be modified to add any library, by specifying git location, similar to library.json

That is essentially how it works already. Anyone is welcome to submit any repository from any of the major Git hosting services. There is no requirement for it to be the library maintainer that makes the submission.

However, the library must be compliant with the requirements. From a quick glance, these libraries are compliant, except for one very important thing: a Git tag. Unfortunately, these repositories don't contain any tags. It would only take a matter of seconds to add them, but only someone with write permissions in the repository could do it.

khoih-prog added a commit that referenced this pull request Aug 10, 2022
### Releases v1.8.2

1. Fix library.properties to remove unavailable items from depends. Check [Remove unavailable items from depends field of library.properties #35](#35)
2. Remove lorol's LittleFS_esp32 library dependency as LittleFS has been included in new ESP32 cores v1.0.6+
3. Fix compile error for [AsyncHTTPRequest_ESP_WiFiManager example](https://github.com/khoih-prog/AsyncHTTPRequest_Generic/tree/master/examples/AsyncHTTPRequest_ESP_WiFiManager)
4. Update `Packages' Patches`
khoih-prog added a commit that referenced this pull request Aug 10, 2022
### Releases v1.8.2

1. Fix library.properties to remove unavailable items from depends. Check [Remove unavailable items from depends field of library.properties #35](#35)
2. Remove lorol's LittleFS_esp32 library dependency as LittleFS has been included in new ESP32 cores v1.0.6+
3. Fix compile error for [AsyncHTTPRequest_ESP_WiFiManager example](https://github.com/khoih-prog/AsyncHTTPRequest_Generic/tree/master/examples/AsyncHTTPRequest_ESP_WiFiManager)
4. Update `Packages' Patches`
@khoih-prog
Copy link
Owner

Hi @per1234

The new AsyncHTTPRequest_Generic releases v1.8.2 has just been published thanks to your PR. Your contribution is noted in Contributions and Thanks

Best Regards,


Releases v1.8.2

  1. Fix library.properties to remove unavailable items from depends. Check Remove unavailable items from depends field of library.properties #35
  2. Remove lorol's LittleFS_esp32 library dependency as LittleFS has been included in new ESP32 cores v1.0.6+
  3. Fix compile error for AsyncHTTPRequest_ESP_WiFiManager example
  4. Update Packages' Patches

@khoih-prog
Copy link
Owner

Hi @per1234

Anyone is welcome to submit any repository from any of the major Git hosting services. There is no requirement for it to be the library maintainer that makes the submission.

IMO, you're the best person to have them added into Arduino Library Manager and provide good services to the community.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants