Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some note with php calendar extension #45

Merged
merged 3 commits into from
Sep 3, 2022

Conversation

moghwan
Copy link
Contributor

@moghwan moghwan commented Sep 2, 2022

in some cases (as it happened to me) the calendar extension is disabled.

in some cases (as it happened to me) the calendar extension is disabled.
@khaled-alshamaa
Copy link
Owner

Thank you @moghwan for this notification! Well, it was a bit weird to find a PHP server setup without calendar extension, it's rare, but a good catch as well.

But instead of mentioning that in the project readme file, I prefer if you include it in the composer.json file just like what we did for the mbstring extension:

"ext-calendar": "*"

Please update your PR accordingly to merge it and welcome you on the Ar-PHP contributers my friend Marwane ;-)

@moghwan
Copy link
Contributor Author

moghwan commented Sep 3, 2022

It's done, I reverted back the edit of README.md as well.
FYI it happened to me because of my LAMPP stack install from scratch and the default php.ini had the extension disabled; Thus an error occured as Call to undefined function ArPHP\I18N\gregoriantojd().

And thanks for the library Mr Khaled :D.

edit: original issue described

@khaled-alshamaa khaled-alshamaa merged commit 5ca3ce0 into khaled-alshamaa:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants