Add option to hide the "playback" message #13

Valinwolf · 2019-07-30T09:29:14Z

PR that implements #12

kgraefe · 2019-07-30T21:21:28Z

Thanks for your contribution. I think that should be a plugin preference rather than a account preference, though (see e.g. the offlinemsg plugin).

kgraefe · 2019-07-30T21:22:47Z

src/znchelper.c

@@ -98,6 +98,7 @@ static void znc_write_chat(
 	PurpleConversation *conv, const char *who, const char *message,
 	PurpleMessageFlags flags, time_t mtime
 ) {
+	PurpleConnection *gc = purple_conversation_get_gc(conv);


Also please don't mix up declarations and code and make sure to check the return values.

I'll fix that right now.

commit added to fix this

Valinwolf · 2019-07-30T22:54:46Z

Thanks for your contribution. I think that should be a plugin preference rather than a account preference, though (see e.g. the offlinemsg plugin).

I actually agree with you, but I was only using the code I had (this plugin) to formulate the code. I'm not very well versed in C. I can do Java, Python, PHP, and more all day, but C and friends are not a strong suit for me. I'll look into fixing that.

Heavy handed Ctrl-C work done from offlinemsg.c

Valinwolf · 2019-07-30T23:39:20Z

All discussed changes have been made. Commits are ready for re-review.

kgraefe · 2019-07-31T12:03:05Z

src/znchelper.c

@@ -37,6 +37,8 @@ static gboolean core_quitting = FALSE;
 #define ZNC_CONV_STATE_START 0
 #define ZNC_CONV_STATE_REPLAY 1
 #define ZNC_CONV_STATE_DONE 2
+#define PREF_PREFIX "/plugins/core/znc-helper"
+#define	PREF_HIDEMSG PREF_PREFIX "/hidemsg"


This Tab should be a space.

kgraefe · 2019-07-31T12:03:22Z

src/znchelper.c

@@ -102,7 +104,7 @@ static void znc_write_chat(
 	struct znc_conn *znc;
 	GList *parted, *l;
 	gint state;
-
+	


Remove whitespace

kgraefe · 2019-07-31T12:04:07Z

src/znchelper.c

@@ -463,6 +469,7 @@ static gboolean plugin_load(PurplePlugin *plugin) {
 		_("Uses ZNC bouncer"), "uses_znc_bouncer", FALSE
 	);
 	irc_info->protocol_options = g_list_append(irc_info->protocol_options, option);
+


Remove newline

kgraefe · 2019-07-31T12:05:13Z

src/znchelper.c

+	PurplePluginPref *pref;
+
+	frame = purple_plugin_pref_frame_new();
+


kgraefe · 2019-07-31T12:07:03Z

LGTM apart from a few whitespace issues.

kgraefe · 2019-07-31T14:19:06Z

Thank you.

Valinwolf added 2 commits July 30, 2019 02:53

Add option to hide playback message

8d94950

Fixed undefined variable

5404995

kgraefe reviewed Jul 30, 2019

View reviewed changes

Valinwolf added 2 commits July 30, 2019 17:59

Added code safety & separated declaration of gc

e99e77d

Convert from account to plugin setting

752b3ba

Heavy handed Ctrl-C work done from offlinemsg.c

Valinwolf added 2 commits July 30, 2019 18:42

Removed code no longer necessary

4081942

Remove more residual code

d956426

kgraefe reviewed Jul 31, 2019

View reviewed changes

src/znchelper.c Outdated

PurplePluginPref *pref;

frame = purple_plugin_pref_frame_new();

Copy link

Owner

kgraefe Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove tab

Fix whitespace

72e708e

kgraefe merged commit a56ff23 into kgraefe:master Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to hide the "playback" message #13

Add option to hide the "playback" message #13

Valinwolf commented Jul 30, 2019

kgraefe commented Jul 30, 2019

kgraefe Jul 30, 2019

Valinwolf Jul 30, 2019

Valinwolf Jul 30, 2019

Valinwolf commented Jul 30, 2019

Valinwolf commented Jul 30, 2019

kgraefe Jul 31, 2019

kgraefe Jul 31, 2019

kgraefe Jul 31, 2019

kgraefe Jul 31, 2019

kgraefe commented Jul 31, 2019

kgraefe commented Jul 31, 2019

		PurplePluginPref *pref;

		frame = purple_plugin_pref_frame_new();