Use XDG_CACHE_HOME for xsel.log #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't write logfiles into the users home directory thats just rude :)
|
@lolilolicon I'm pretty much done with this, feel free to send a patch. |
e7appew
added a commit
to e7appew/xsel
that referenced
this pull request
Mar 29, 2017
kfish#15 introduces some side-effects. The HOME environment variable is modified, and more likely than not, it overflows the string's buffer. Make sure we return the string in memory we've allocated ourselves to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
XDG_CACHE_HOME(or$HOME/.cacheif the environment variable is not set)instead of putting the logfile directly into the users home directory