Fixes redirect to signin page in @keystone-6/auth when using basePath
#8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
borisno2
changed the title
@keystone-6/auth when using basePath@keystone-6/auth when using basePath
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0955ece:
|
dcousens
approved these changes
Jun 19, 2023
Merged
|
I upgraded to "@keystone-6/core": "^5.3.0" last Friday because I wanted to use ui.basePath, I noticed that something was wrong with the redirects but couldn't investigate much to understand so I left it there. Today I had a closer look and found this MR. It fixed my app, and just in the right moment! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/signinredirection when basePath is changed to/admin#8637This pull request adds the user provided
ui.basePathto thepublicPagesused by@keystone-6/authto ensure that when re-directing to/signin, the user actually lands on${basePath}/signin.As part of this change, we added
basePathto thepageMiddlewarefunction, to support other custom middleware in fixing their functionality too.