Update prettier to be CI-friendly #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind if we merge keystonejs/keystone-5#49 first? There'll be a lot of conflicts otherwise. |
jesstelford
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out
prettier_lint(as distinct fromformatandlint) to allow it to be run in isolation on Circle CI.This allows for more specific failure reporting on Circle CI and gives devs the flexibility to run eslint and prettier as separate scripts if desired.
We also remove the specific
lint_ciandjest_ciscripts and move their functionality into.circleci/config.yml, which keeps all the details of where they send their output in a single location.We also update all the existing code to be prettier-compliant.
Finally, we add a Circle CI badge to the
READMEso we can all feel good about our tests passing 🎉