Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin UI: minor cleanup to useList #3259

Closed

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Jul 19, 2020

  • Removed unnecessary manual query refetches (already handled via refetchQueries)
  • Removed the query property from useList
  • Added loading and error to useList
  • Stop passing query through to ListLayout via prop

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2020

🦋 Changeset is good to go

Latest commit: 0b56293

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/app-admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gautamsi
Copy link
Member

Hey, query is needed for re-fetching manually after making changes in listmanageActions UI hooks, I am sure you can suggest alternative. should this be refetchQueries in my mutations?

@Vultraz
Copy link
Contributor Author

Vultraz commented Jul 20, 2020

refetchQueries is the pattern I've been using, but I can add refetch directly to the hook if you would prefer to use that.

@gautamsi
Copy link
Member

Let me try that, we would have to document this.

@gautamsi
Copy link
Member

gautamsi commented Aug 2, 2020

I think I am fine with the refetchQueries approach, go ahead if you were waiting for my feedback.

@stale
Copy link

stale bot commented Dec 1, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Dec 1, 2020
@stale stale bot removed the needs-review label Apr 8, 2021
@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Thanks for this PR @Vultraz.

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old PRs such as this one.

However, you are welcome to create a PR under the Keystone 5 repository.

Please let me know if you have any questions.

@bladey bladey closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants