This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
add twig templating language #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a first glance this looks excellent, I think ripping out Swig in favor of Twig is a good way to go here. To test it, you should run the generator, choose Twig and verify that the results you get are ~the same ones as before. |
|
Thanks @r3wt, this looks great. I'm 👍 to merge. If you want to, it would be great to have another PR taking swig out! |
|
Sure thing @JedWatson when i get off work i will submit a PR removing swig. also, would you mind to weigh in on keystonejs/keystone#2734 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #180
thus far, only twig is added, swig is not removed. unsure how to test. please advise.