-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More generalized method of getting and setting the attestation. #5
Conversation
This latest push addresses the issue described here: #6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I'd prefer to split all of the rebuild-hash-using-qemu code into its own make target for portability. (Some folks will be targeting just the hifive, not qemu)
I agree with what you are saying. Is this more of what you were thinking of? I had just done the first because I forgot about targeting anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more small changes. Primarily paths must be either relative, or based off a config or pwd
if they have to be absolute.
I made a standalone script
get_attestation.sh
which is still specific for this project but will generate the attestation results. I also modified the Makefile so that it will build correctly.