Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generalized method of getting and setting the attestation. #5

Merged
merged 13 commits into from
Mar 5, 2019

Conversation

ThaumicMekanism
Copy link
Contributor

I made a standalone script get_attestation.sh which is still specific for this project but will generate the attestation results. I also modified the Makefile so that it will build correctly.

@ThaumicMekanism
Copy link
Contributor Author

This latest push addresses the issue described here: #6

@dayeol dayeol requested a review from dkohlbre March 4, 2019 19:43
Copy link
Collaborator

@dkohlbre dkohlbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I'd prefer to split all of the rebuild-hash-using-qemu code into its own make target for portability. (Some folks will be targeting just the hifive, not qemu)

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ThaumicMekanism
Copy link
Contributor Author

I agree with what you are saying. Is this more of what you were thinking of? I had just done the first because I forgot about targeting anything.

Copy link
Collaborator

@dkohlbre dkohlbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more small changes. Primarily paths must be either relative, or based off a config or pwd if they have to be absolute.

source.sh Outdated Show resolved Hide resolved
scripts/extract_hash.sh Outdated Show resolved Hide resolved
@dkohlbre dkohlbre merged commit 060d3eb into keystone-enclave:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants