Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fv: replace Zip framework to prevent crash on startup 🏠 #9958

Merged
merged 6 commits into from
Nov 22, 2023
Merged

fix(ios): fv: replace Zip framework to prevent crash on startup 🏠 #9958

merged 6 commits into from
Nov 22, 2023

Conversation

sgschantz
Copy link
Contributor

@sgschantz sgschantz commented Nov 7, 2023 •
edited
Loading

Replacing marmelroy/Zip framework with weichsel/ZIPFoundation due to problems with using the Zip framework and Carthage. Attempts to use Zip framework were unsuccessful in #9942

Fixes #9819

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 7, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(ios): fv: replace Zip framework to prevent crash on startup fix(ios): fv: replace Zip framework to prevent crash on startup 🏠 Nov 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S25 milestone Nov 7, 2023
@sgschantz sgschantz mentioned this pull request Nov 8, 2023
Closed
@darcywong00
Copy link
Contributor

From standup - we'll need to

  • thoroughly test the unzipping
  • notify consumers of Keyman Engine for iOS (KAB, FV, etc)

@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@sgschantz sgschantz mentioned this pull request Nov 16, 2023
Merged
@sgschantz sgschantz self-assigned this Nov 21, 2023
@sgschantz sgschantz marked this pull request as ready for review November 21, 2023 07:17
@darcywong00 darcywong00 linked an issue Nov 21, 2023 that may be closed by this pull request
bug(ios): FV Keyboards stable-16.0.142 app crashes on launch #9819
Closed
mcdurdin
mcdurdin approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Can you add "Cherry-pick of #xxxx" where xxxx is the PR on master to the initial comment?

@sgschantz
Copy link
Contributor Author

RSLGTM

Can you add "Cherry-pick of #xxxx" where xxxx is the PR on master to the initial comment?

I could but I was calling #10018 a cherry-pick of this PR. I wrote this one first, but I moved it to 17 to gain testing via TestFlight. Should I add to the comment that this is cherry-picked by #10018? I'm figuring that they cannot be cherry-picking each other...

@mcdurdin
Copy link
Member

I'm figuring that they cannot be cherry-picking each other...

Oh I see, carry on then as you were 😁

@sgschantz sgschantz merged commit 0b02b39 into stable-16.0 Nov 22, 2023
5 checks passed
@sgschantz sgschantz deleted the fix/fv/9819-replace-zip-library branch November 22, 2023 06:49
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 16.0.143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees

@sgschantz sgschantz

Labels
fix ios/app/ ios/engine/ ios/samples/ ios/ oem/fv/ios/ oem/fv/ oem/ stable
Projects
None yet
Milestone
A17S26
Development

Successfully merging this pull request may close these issues.

bug(ios): FV Keyboards stable-16.0.142 app crashes on launch
4 participants
@sgschantz @darcywong00 @mcdurdin @keyman-server