chore: rename km_kbp_ to km_core_ #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
windows/
developer/
linux/
common/
linux/engine/
core/
mcdurdin
requested review from
rc-swag,
ermshiperete and
darcywong00
as code owners
darcywong00
reviewed
Oct 9, 2023
rc-swag
reviewed
Oct 10, 2023
| Set(KM_CORE_KMX_ENV_BASELAYOUT, DEFAULT_BASELAYOUT); | ||
| Set(KM_CORE_KMX_ENV_BASELAYOUTALT, DEFAULT_BASELAYOUTALT); | ||
| Set(KM_CORE_KMX_ENV_SIMULATEALTGR, DEFAULT_SIMULATEALTGR); | ||
| Set(KM_CORE_KMX_ENV_BASELAYOUTGIVESCTRLRALTFORRALT, DEFAULT_BASELAYOUTGIVESCTRLRALTFORRALT); |
There was a problem hiding this comment.
We could trim these down too (maybe seperate PR) KM_CORE_KMX_ENV_PLATFORM => KM_CORE_KMX_PLATFORM
or even drop the KMX_ also
There was a problem hiding this comment.
We could ... but the longer name clarifies that these are really only used by the KMX environment at present.
Base automatically changed from
chore/core/9721-rename-keyboardprocessor.h-to-keyman_core_api.h
to
master
October 10, 2023 00:57
|
Changes in this pull request will be available for download in Keyman version 17.0.187-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9722.
@keymanapp-test-bot skip