feat(developer): add &displayMap system store 🗜
#9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The &displayMap system store adds support for a mapping file that remaps the On Screen Keyboard files -- .kvks and .keyman-touch-layout, at compile time, to new ranges. This is specifically intended to resolve a limitation of unattached marks and diacritics which display inconsistently across platforms; this is described in more detail in issue #9031.
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
common/
common/web/
developer/
developer/compilers/
feat
labels
keymanapp-test-bot
bot
removed
the
user-test-missing
This was
linked to
issues
Jun 18, 2023
jahorton
approved these changes
Jun 19, 2023
Base automatically changed from
feat/developer/analyze-char-use-continued
to
feature-kmc-kmw
June 20, 2023 06:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9031.
Fixes #1070.
Builds on #9016.
The
&displayMapsystem store adds support for a mapping file that remaps the On Screen Keyboard files -- .kvks and .keyman-touch-layout, at compile time, to new ranges. This is specifically intended to resolve a limitation of unattached marks and diacritics which display inconsistently across platforms; this is described in more detail in issue #9031.In draft because this still needs work for KMW compiler -- but need to do some refactoring on KMW compiler, inverting dependency on kmc-kmn so that kmc-kmn calls into kmc-kmw, before this will be achievable.
Related PRs:
&displayMapreference 🗜 help.keyman.com#731TODO:
&displayMapreference 🗜 help.keyman.com#731&displayMapreference 🗜 help.keyman.com#731&displayMapreference 🗜 help.keyman.com#731, also in this PR@keymanapp-test-bot skip (testing will be in keyboards PR, once 17.0 tooling is in place)