change(web): internal-event convention consistency 🧩 #9012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #8560:
From a review comment on #8591:
So... I somehow wasn't fully aware until now that event names in JS are conventionally set to full lowercase, as are our pre-existing documented API events, and I'd gone making a number of camel-cased internal event names. This PR corrects my mistakes and sets them to their lowercase-convention form. I'm still not personally super-comfortable with it for certain names, but it's best to follow conventions.
@keymanapp-test-bot skip