fix(common): preserve const enums in tsc build 🌱 #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
2 tasks
mcdurdin
force-pushed
the
fix/common/10486-preserve-const-enums
branch
from
f796fff
to
2aa640e
Compare
Base automatically changed from
fix/developer/10485-missing-imports
to
epic/core/9999-normalization
January 24, 2024 04:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10486.
Note: we are not enabling this globally, because KeymanWeb can break on some of its modules. Something for us to consider for the future.
I audited usage of const enum elsewhere and found it only in common/web/types and developer/src/kmc-kmn.
@keymanapp-test-bot skip