fix(developer): verify context(n) offsets are valid in kmcmplib
#13308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
commented
Feb 21, 2025
| @@ -2267,7 +2277,9 @@ KMX_DWORD GetXStringImpl(PKMX_WCHAR tstr, PFILE_KEYBOARD fk, PKMX_WCHAR str, KMX | |||
| } | |||
| int n1b; | |||
| n1b = atoiW(q); | |||
| if (n1b < 1 || n1b >= 0xF000) return KmnCompilerMessages::ERROR_InvalidToken; | |||
| if (n1b < 1 || n1b >= 0xF000) { | |||
| return KmnCompilerMessages::ERROR_ContextExHasInvalidOffset; | |||
There was a problem hiding this comment.
This is a clearer error message, no functional change.
This was
linked to
issues
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validity checks to kmcmplib to verify that offsets provided to
context(n)are in range for the context, and do not point to non-character elements (nulandif) in the context string.Fixes: #13301
Fixes: #13302
Relates-to: #13299
Relates-to: #13276
@keymanapp-test-bot skip