Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): Add an extra kmc check and message for context(n) index being correct #13301

Open
mcdurdin opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13308
Open

feat(developer): Add an extra kmc check and message for context(n) index being correct #13301

mcdurdin opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13308
Assignees
@mcdurdin
Labels
developer/ feat
Milestone
B18S2

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Feb 21, 2025 •
edited
Loading

It looks like it might be out of bounds for some rules.

i.e. n >= 1 && n <= len(context)
@mcdurdin mcdurdin changed the title Add an extra kmc check and message for context(n) index being correct because it looks like it might be out of bounds for some rules feat(developer): Add an extra kmc check and message for context(n) index being correct Feb 21, 2025
@mcdurdin mcdurdin added this to the B18S2 milestone Feb 21, 2025
@mcdurdin mcdurdin self-assigned this Feb 21, 2025
@mcdurdin mcdurdin moved this to In Progress in Keyman Feb 21, 2025
mcdurdin added a commit that referenced this issue Feb 21, 2025
@mcdurdin
fix(developer): verify context(n) offsets are valid in kmcmplib
4a797d0 
Add validity checks to kmcmplib to verify that offsets provided to
`context(n)` are in range for the context, and do not point to
non-character elements (`nul` and `if`) in the context string.

Fixes: #13301
Fixes: #13302
Relates-to: #13299
Relates-to: #13276
@mcdurdin mcdurdin linked a pull request Feb 21, 2025 that will close this issue
Draft
@mcdurdin mcdurdin linked a pull request Feb 21, 2025 that will close this issue
fix(developer): verify context(n) offsets are valid in kmcmplib #13308
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
developer/ feat
Projects
Keyman
Status: In Progress
Milestone
B18S2
Development

Successfully merging a pull request may close this issue.

fix(developer): verify context(n) offsets are valid in kmcmplib keymanapp/keyman
1 participant
@mcdurdin