Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(android): DOMRect polyfill needed for early ES6 devices #11652

Closed
sentry-io bot opened this issue Jun 3, 2024 · 1 comment · Fixed by #11653 or #13012
Closed

bug(android): DOMRect polyfill needed for early ES6 devices #11652

sentry-io bot opened this issue Jun 3, 2024 · 1 comment · Fixed by #11653 or #13012
Assignees
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 3, 2024

Sentry Issue: KEYMAN-WEB-JD

Error:  Error from queued closure: DOMRect is not defined

ReferenceError: DOMRect is not defined
    at se.getBoundingClientRect (file:///data/user/0/com.tavultesoft.kmapro/app_data/keymanweb-webview.js:15:6053)
    at itemIdentifier (file:///data/user/0/c...
  at Nr.<anonymous> (@keymanapp/keyman/common/web/gesture-recognizer/src/engine/headless/asyncClosureDispatchQueue.ts:60:7)
  at Generator.next (<anonymous>)
  at Promise (<anonymous>)
  at AsyncClosureDispatchQueue.triggerNextClosure (@keymanapp/keyman/common/web/gesture-recognizer/src/engine/headless/asyncClosureDispatchQueue.ts:39:38)
  at Nr.<anonymous> (@keymanapp/keyman/common/web/gesture-recognizer/src/engine/headless/asyncClosureDispatchQueue.ts:83:10)
...
(23 additional frame(s) were not displayed)

Per MDN, DOMRect requires Chrome 61, which is later than full ES6 support was added. Despite this, the ES6 version of the keyboard host-page does not include the DOMRect polyfill that the ES5 version does.

@jahorton
Copy link
Contributor

Reopening due to breakage occurring from merge of #11881, which unlinked this polyfill despite not raising the minimum requirements enough to mitigate the need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment