Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(developer): add warning or error if virtual key used in output of rule #10059

Closed
mcdurdin opened this issue Nov 23, 2023 · 0 comments · Fixed by #10062
Closed

chore(developer): add warning or error if virtual key used in output of rule #10059

mcdurdin opened this issue Nov 23, 2023 · 0 comments · Fixed by #10062
Labels
chore developer/
Milestone
A17S26

Comments

@mcdurdin
Copy link
Member

See also #10049.

This has never been officially supported and never worked properly; Core never passed anything to Engines, so vk output has not worked at all since Core was integrated anyway. Time to let our keyboard developers know!
This was referenced Nov 23, 2023
Closed
Merged
mcdurdin added a commit that referenced this issue Nov 23, 2023
@mcdurdin
feat(developer): warn on usage of virtual keys in rule output
e983818 
Fixes #10059.

Use of the unsupported and undocumented virtual key output, that doesn't
work in recent Keyman versions, at all, now results in a build warning.

Only a warning, because it did kinda work in old versions of Keyman.
@mcdurdin mcdurdin added this to the A17S26 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore developer/
Projects
None yet
Milestone
A17S26
Development

Successfully merging a pull request may close this issue.

feat(developer): warn on usage of virtual keys in rule output keymanapp/keyman
1 participant
@mcdurdin