fix: Modify stable url for keyboard download to kmp file #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Hmm, is this a much older bug, not actually coming out of the Apache/docker transition? Let's make sure we get it right for all patterns. The bundled installer .exe is now actually not a "bundle" but a file name pattern which causes the bundle to download (see https://kmn.sh/kb35, keyman-setup filename patterns section), so we may need to do some more work to get that right.
| @@ -8,7 +8,8 @@ RedirectMatch "/go/(([1-9][0-9])([.]?)([0-9]))/developer-help-(mobile|packages)( | |||
| # Download redirects for keyboard permalinks (TODO: these three rules need refresh) | |||
|
|
|||
| # download-kmp | |||
| RedirectMatch "/go/keyboard/([^/?]+)/download/kmp$" "/keyboards/download?id=$1&platform=windows&mode=standalone" | |||
| # Modified to match download-package below | |||
| RewriteRule "^keyboard/([^/]+)/download/kmp$" "package/download.php?type=keyboard&id=$1" [END,QSA] | |||
|
|
|||
| #download-exe | |||
| RedirectMatch "/go/keyboard/([^/?]+)/download/exe$" "/keyboards/download?id=$1&platform=windows&mode=bundle" | |||
There was a problem hiding this comment.
What about this rule and download-js? They also seem to be wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474
From the reported issue,
We want to change /go/keyboard/**/download/kmp to match the behavior of /go/package instead of going to a keyboard landing page.
This modifies the rule in .htaccess to match what /go/package does.
keyman.com/go/.htaccess
Lines 27 to 28 in b695ba0
The links can be manually compared on
keyman.com/_test/go.md
Lines 348 to 354 in b695ba0
Until this PR is merged, localhost will redirect to the kmp file while the live site still goes to the keyboard page.