-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authFlow): added optional priority #1040
feat(authFlow): added optional priority #1040
Conversation
b456625
to
cb1d4e2
Compare
Have you seen #970 ? |
I am currently working on migrating all features that I built in my repo, while the project was not responsive. TBH: I don´t mind which PR we are going to merge ;) |
@denniskniep @gim- Thanks for your work so far! I agree with @denniskniep to keep version checks in the provider package. On the other hand @gim- also adapted the data source which is missing in this PR. Can we somehow merge the two PRs? |
* Added optional priority to AuthenticationExecution * Added optional priority to AuthenticationSubFLow Closes: keycloak#296 Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
cb1d4e2
to
d17baa5
Compare
@gim- Are you fine with going for this PR instead of yours? |
Ok, I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everybody!
Closes: #296