Distribute code with ES module syntax #381
Conversation
|
Everything is compiling as expected and the tests are passing, however this code will not yet work as expected when consumed. The reason for this is that a file extension is required (see 'Mandatory file extensions' in the NodeJS documentation). The TypeScript compiler does not support this as it is a design choice to ensure that JS code is not transformed microsoft/TypeScript#15479 (comment). So we'lll have to come up with a solution to transform the code accordingly. |
|
Looks like the nightly version of TypeScript has support for this new module convention in NodeJS (see the documentation). This feature was supposed to land in version 4.5 but has been deferred due to to concerns over developer experience (more in the release blog post). I"m going to see how much effort it would be to implement this flag, also out of curiosity what the impact would be. |
|
Ok, so most of the issues have been fixed. However some dependencies we are using are not properly resolved at the moment. This seems to be because they are not including types, and the compiler cannot resolve the installed type packages. |
jonkoops
force-pushed
the
es-modules
branch
2 times, most recently
from
fc6776b to
1eeb4f1
Compare
jonkoops
force-pushed
the
es-modules
branch
4 times, most recently
from
c34a9f8 to
0f562b1
Compare
|
Okay, the last issues have been resolved. I am marking this as ready to be reviewed. |
Closes #380. More information about pure ESM packages here.