Add Dockerfile and integration tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 11, 2019
| RUN useradd -ms /bin/bash keybase | ||
| USER keybase | ||
| WORKDIR /home/keybase | ||
| RUN curl --remote-name https://prerelease.keybase.io/keybase_amd64.deb |
There was a problem hiding this comment.
i hit issues a while back with this being really old and failing something. maybe not an issue, but this is how to get more up-to-date versions. might be better to keep the old one. /shrug
https://prerelease.keybase.io/nightly/keybase_amd64.deb
There was a problem hiding this comment.
Until we see issues with this, I think it is best to stick with that link (which is listed as the stable release on our website). Given the nature of this project, I don't think it is a good idea to recommend running it on top of nightly builds unless truly necessary.
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 11, 2019
xgess
reviewed
Jul 15, 2019
xgess
reviewed
Jul 15, 2019
xgess
reviewed
Jul 15, 2019
xgess
reviewed
Jul 15, 2019
xgess
reviewed
Jul 15, 2019
xgess
reviewed
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Dockerfile and directions on how to run the bot inside of Docker. Uses docker-compose and two additional docker containers to run full integration tests that test kssh and keybaseca working together. See the README for directions on how to run integration tests.
In order to get all of this to work inside of Docker, I also migrated all of the code to use
keybase fssubcommands rather than reading from/keybase/. Running FUSE inside of docker requires giving the container theSYS_ADMINcapabilit which effectively disables the sandbox. With this change, it is not necessary to run FUSE inside of the container.