New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field types #385

Merged

andresailer merged 2 commits into key4hep:main from andresailer:fixTypes

Sep 2, 2024

Contributor

andresailer commented Aug 30, 2024 •

edited

Loading

BEGINRELEASENOTES

FieldMapXYZ, FieldMapBrBz: adapt to variable rename from DD4hep, fix "OverlayedField ERROR add: Attempt to add an unknown field type.", fixes Fieldmap not correctly imported #384

ENDRELEASENOTES

andresailer added 2 commits

August 30, 2024 16:40


          Fields: correct type to field_type, changed variable name in DD4hep, …

3c1d83a

…type still exists as part of handle


          Tests: move one test to something with fieldmaps

74411e9

andresailer requested a review from tmadlener

August 30, 2024 14:40

Contributor Author

andresailer commented Aug 30, 2024

@tmadlener : just because I touch the ILD tests I asked for your review, but seems good to have one test using fieldmaps :)

tmadlener approved these changes

View reviewed changes

andresailer merged commit a3b1303 into key4hep:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet