Fix printout issues in turbine endcap geometry; also add v02 of the geometry #379

varnes · 2024-08-22T15:45:17Z

BEGINRELEASENOTES

ECalEndcap_Turbine_o1_v01_geo: Fix issues with printout (to allow verbosity to be controlled from run script).
Add ECalEndcap_Turbine_o1_v02_geo of the "turbine" endcap geometry: which allows for more flexibility than v01 (for example, one can set different blade angles for the three wheels in v02). As v02 is still a work in progress, the default xml points to v01.

ENDRELEASENOTES

giovannimarchiori · 2024-09-03T09:49:25Z

Hi @varnes,
what's the status of this PR? Do you still need to further modifications to v02 or is it ready to go?
Can you rebase and fix the conflicts so that the tests can be run?
Also, can you please add comments in the main xml to describe the CellID encoding bitfield?
Thanks a lot,
Giovanni

giovannimarchiori · 2024-09-13T15:31:44Z

@BrieucF I would really like to merge soon this PR so that we can get rid of the tons of debug messages in regular output. Maybe we move ahead with this (after rebasing) and leave it to a future PR further developments on v02 (if any)?

andresailer · 2024-09-16T06:39:37Z

@varnes you need to rebase and fix conflicts

BrieucF · 2024-09-16T09:16:32Z

Hi Giovanni, yes, let's merge this asap. @varnes while you rebase and fix the conflicts, would you mind updating the relevant README with information about v02: https://github.com/key4hep/k4geo/tree/main/detector/calorimeter#ecalendcap_turbine, https://github.com/key4hep/k4geo/tree/main/FCCee/ALLEGRO/compact#allegro ?

Add a lumical_max_z_prime parameter to get the actual end place of the lumical add 7 micron meter to the envelopes. Fix the location and rotation to use the max_z_prime values

…nertracker

…rimed and unprimed

…type still exists as part of handle

…ep#387)

… of algobal union of intersections... No overlaps detected and the finding points on surface does not complain any more

at least the lumical specific overlap check with /geometry/test/resolution 300000 is much faster now as well???

… MDI (key4hep#388) * apply Tracker_limits to the volume inside of beampipe and related MDI elements --------- Co-authored-by: JEANS Daniel Thomelin Dietrich <jeans@cw07.cc.kek.jp>

…E file

varnes · 2024-09-18T01:15:06Z

Hi @BrieucF and @giovannimarchiori ,

Sorry for being slow on this (some combination of a family event and the messages ending up in my spam folder contributed). But I think it's ready now...

Erich Varnes and others added 14 commits August 8, 2024 14:29

Fix bug in cell y position for -z endcap

Loading
Loading status checks…

2c2ad14

Merge branch 'main' into EWV_positionfix2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

3ec3062

Merge branch 'main' into EWV_positionfix2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

6476b5c

Add v02 of turbine endcal ecal

3d13b7a

Fix up some printouts

e6e406c

Fix printouts

568f1f4

Fix printouts

9239039

Fix printouts

467ad06

Resolve conflicts

75dd72f

update for v2 geometry

6047627

Fix printouts

0d62be1

Fix printouts

7f80d06

Update to be compatible with v2 segmentation

737c1bb

Fix printout

cf46b28

varnes changed the title ~~Turbinev2 fixprintout~~ Fix printout issues in turbine endcap geometry; also add v02 of the geometry Aug 22, 2024

BrieucF mentioned this pull request Sep 17, 2024

Release 2024-09-20ish key4hep/key4hep-spack#647

Closed

19 tasks

atolosadelgado and others added 10 commits September 17, 2024 16:12

comment include of DRC in IDEA o1 v3

ef7c9bb

IDEA with DRC dedicated test added

afbfa4e

fix IDEA with DRC test

f103aa2

apply other SD action to DRC

b2d7b2a

update IDEA README

bd809d7

still not working...

575980f

replace absolute path by cmake variables in ctest

1e3c045

fix test_IDEA_o1_v03 by removing DRC steering file

505c3ea

IDEA+DRC test is now working

95b9208

Fix a few compiler warnings (key4hep#374)

3fa319e

mmlynari and others added 28 commits September 17, 2024 16:12

fix failing test and remove unused phi segmentation

d341a1e

fix endcap bitfields and improve readibility

7a2d014

keep ALLEGRO v03 xml file unchanged

2d40d86

adding version nr also for the barrel xml

5ac8f83

update hcal xml files to v02

d0bf78b

add back ECalEndcaps_Turbine

f55bdd5

remove unused hcal v01 xml files

042f6f6

update READMEs

a7199de

add HCalTileBarrel_o1_v02_geo.cpp

557ae09

CLD_o2_v07: start with new lumical to fix overlaps

ceb15aa

CLD_o2_v07: fix overlaps in the LumiCal itself

25629c6

Add a lumical_max_z_prime parameter to get the actual end place of the lumical add 7 micron meter to the envelopes. Fix the location and rotation to use the max_z_prime values

CLD_o2_v07: remove old lumical xml

a082a1b

CLD_o2_v07: InnerTracker: fix envelope overlap between lumical and in…

e27f504

…nertracker

Tests: move CLD test to latest model

3bab7cd

CLD_o2_v07: account for lumical positioning with difference between p…

00194d5

…rimed and unprimed

Fields: correct type to field_type, changed variable name in DD4hep, …

4b35150

…type still exists as part of handle

Tests: move one test to something with fieldmaps

96f71f4

Do not link against podio and EDM4hep dictionaries (key4hep#386)

822d54a

Add a Key4hepConfig file

7c29164

Update Key4hepConfig.cmake with fixes from key4hep/key4hep-dev-utils#7

3f99506

Use the Key4hepConfig flag to set the standard, compiler flags (key4h…

ee45761

…ep#387)

CLD_o2_v07: LumiCalBackShield: change envelope to an assembly instead…

0a70e03

… of algobal union of intersections... No overlaps detected and the finding points on surface does not complain any more

CLD_o2_v07: LumiCal: replace all envelopes with assemblies

ae23a93

at least the lumical specific overlap check with /geometry/test/resolution 300000 is much faster now as well???

ILD models: apply Tracker_limits to the volume inside of beampipe and…

d0fb0bc

… MDI (key4hep#388) * apply Tracker_limits to the volume inside of beampipe and related MDI elements --------- Co-authored-by: JEANS Daniel Thomelin Dietrich <jeans@cw07.cc.kek.jp>

Remove unused variable, and add information about o1_v02 to the READM…

97700fc

…E file

Fix merge conflict

Loading
Loading status checks…

4a8d399

Initialize all variables

Loading
Loading status checks…

38c1db6

Initialize all variables

Loading
Loading status checks…

7ecbee3

BrieucF merged commit 8a7c232 into key4hep:main Sep 18, 2024
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix printout issues in turbine endcap geometry; also add v02 of the geometry #379

Fix printout issues in turbine endcap geometry; also add v02 of the geometry #379

varnes commented Aug 22, 2024 •

edited by BrieucF

Loading

giovannimarchiori commented Sep 3, 2024

giovannimarchiori commented Sep 13, 2024

andresailer commented Sep 16, 2024

BrieucF commented Sep 16, 2024

varnes commented Sep 18, 2024

Fix printout issues in turbine endcap geometry; also add v02 of the geometry #379

Fix printout issues in turbine endcap geometry; also add v02 of the geometry #379

Conversation

varnes commented Aug 22, 2024 • edited by BrieucF Loading

giovannimarchiori commented Sep 3, 2024

giovannimarchiori commented Sep 13, 2024

andresailer commented Sep 16, 2024

BrieucF commented Sep 16, 2024

varnes commented Sep 18, 2024

varnes commented Aug 22, 2024 •

edited by BrieucF

Loading