Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLD_o2_v07 #369

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Add CLD_o2_v07 #369

merged 11 commits into from
Aug 28, 2024

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Aug 8, 2024

Improves load time from 33s to 1s on my machine. :)

I am also planning to add layer assemblies for the endcaps, but that is less performance relevant. Additionally, I also want to add a new tracking region definition to exclude the LumiCal now that that is possible.

BEGINRELEASENOTES

  • Added TrackerBarrel_o1_v06 using a stave assembly instead of directly placing the sensors into the layers
  • Added CLD_o2_v07 using the new TrackerBarrel_o1_v06

ENDRELEASENOTES

TODO:

  • Check if surfaces are still pointing in the right directions
  • cleanup, add back the ZPlanarData and NeighbourSurfacesData
  • Physics validation
  • Document better that a module in the xml is not the same as what is called a module in the encoding/structure
  • Add new tracking region
  • Update README
  • Run overlap check
  • Repair surfaces

Evaluation results:

  • Only unrelated overlaps in the LumiCal
  • Tracking surface origin, u and v vector differences between old and new TrackerBarrel less than 1 fm
  • Able to run reconstruction on files produced with the previous version and reproduce exactly the same digitised hits and tracks

@Zehvogel Zehvogel force-pushed the cld-tracker-barrel branch 5 times, most recently from 144be99 to f78e8ae Compare August 12, 2024 11:44
@BrieucF
Copy link
Contributor

BrieucF commented Aug 12, 2024

Hi Leonhard, nice! Can you also update this README when ready?

@Zehvogel Zehvogel force-pushed the cld-tracker-barrel branch from f78e8ae to 5a45023 Compare August 13, 2024 14:19
@Zehvogel Zehvogel mentioned this pull request Aug 13, 2024
@Zehvogel Zehvogel force-pushed the cld-tracker-barrel branch from 5a45023 to 9e76609 Compare August 14, 2024 07:34
@Zehvogel
Copy link
Contributor Author

I added a polycone for the tracking volume to exclude the LumiCal. It should still contain all of the beam pipe seen by prompt particles. Alternatively we could use a boolean shape where just the LumiCal envelope is removed from the cylindrical tracking volume, but I guess that is slightly slower?

I am also not sure yet what the correct setting for connected would be here:

    <!--
       If the volume should be connected to the world:   connected="true"
       else if the volume is part of the parallelworld:  connected="false"
       The volume is always connected to the top level!
    -->
    <parallelworld_volume name="tracking_volume" anchor="/world" material="Air" connected="true"

@Zehvogel
Copy link
Contributor Author

Some references for the people interested in the tracking region business (@atolosadelgado):

AIDASoft/DD4hep#1303
AIDASoft/DD4hep#384

@Zehvogel Zehvogel changed the title [WIP] Add CLD_02_v07 [WIP] Add CLD_o2_v07 Aug 22, 2024
@Zehvogel Zehvogel force-pushed the cld-tracker-barrel branch from 5ad2c9e to dacd59f Compare August 28, 2024 07:50
@Zehvogel
Copy link
Contributor Author

Size of the MCParticles collection when using Geant4TCUserParticleHandler (old) vs. Geant4TVUserParticleHandler (new) for a 100 electrons at 10-100 GeV and theta of 50-100 mrad, i.e. directly into the LumiCal. All the shower particles are no longer in the MCParticle collection :)

image

image

@Zehvogel Zehvogel force-pushed the cld-tracker-barrel branch from dacd59f to e7dc8fa Compare August 28, 2024 08:18
@Zehvogel Zehvogel marked this pull request as ready for review August 28, 2024 08:19
@Zehvogel Zehvogel changed the title [WIP] Add CLD_o2_v07 Add CLD_o2_v07 Aug 28, 2024
@andresailer
Copy link
Contributor

andresailer commented Aug 28, 2024

I have most of the overlaps related to the LumiCal fixed (#376) andresailer@6e48fc5

There is one between the lumical and the innertracker envelope that I still need to work out.

@andresailer
Copy link
Contributor

andresailer commented Aug 28, 2024

image

G4 macro

/vis/open OGLIX 1000x1000+600+400
/vis/viewer/reset
/vis/viewer/set/upVector 1 0 0 
/vis/viewer/set/viewpointVector 0 1 0  
/vis/viewer/set/sectionPlane on 0 0 0 m 0 1 0
/vis/viewer/set/style w

# focus on the lumical vs innnertracker issue
/vis/viewer/zoomTo 30 
/vis/viewer/panTo 1.08 0.16
/vis/geometry/set/forceWireframe all -1 true
/vis/drawVolume

@andresailer
Copy link
Contributor

image

No more overlaps andresailer@df24589

@andresailer
Copy link
Contributor

@Zehvogel Let's merge this, and I make a PR with my commits?

@Zehvogel
Copy link
Contributor Author

ok

@andresailer andresailer merged commit 0e922ed into key4hep:main Aug 28, 2024
6 checks passed
@Zehvogel Zehvogel deleted the cld-tracker-barrel branch August 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants