-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLD_o2_v07 #369
Add CLD_o2_v07 #369
Conversation
144be99
to
f78e8ae
Compare
Hi Leonhard, nice! Can you also update this README when ready? |
f78e8ae
to
5a45023
Compare
5a45023
to
9e76609
Compare
I added a polycone for the tracking volume to exclude the LumiCal. It should still contain all of the beam pipe seen by prompt particles. Alternatively we could use a boolean shape where just the LumiCal envelope is removed from the cylindrical tracking volume, but I guess that is slightly slower? I am also not sure yet what the correct setting for
|
Some references for the people interested in the tracking region business (@atolosadelgado): |
5ad2c9e
to
dacd59f
Compare
dacd59f
to
e7dc8fa
Compare
I have most of the overlaps related to the LumiCal fixed (#376) andresailer@6e48fc5 There is one between the lumical and the innertracker envelope that I still need to work out. |
G4 macro
|
No more overlaps andresailer@df24589 |
@Zehvogel Let's merge this, and I make a PR with my commits? |
ok |
Improves load time from 33s to 1s on my machine. :)
I am also planning to add layer assemblies for the endcaps, but that is less performance relevant. Additionally, I also want to add a new tracking region definition to exclude the LumiCal now that that is possible.
BEGINRELEASENOTES
ENDRELEASENOTES
TODO:
Document better that a module in the xml is not the same as what is called a module in the encoding/structureEvaluation results: