Fix CLD endcap radius calculation for CED #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
approved these changes
Jul 30, 2024
jmcarcell
reviewed
Jul 30, 2024
| if(r - mod_shape->GetDZ()<innerR) | ||
| innerR= r- mod_shape->GetDZ(); | ||
| if(r < innerR) | ||
| innerR = r; |
There was a problem hiding this comment.
A bit pedantic, these cases can be stated like innerR = std::min(innerR, r) which I think better shows the intention (this case is trivial but the other one is longer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radius calculation was very broken, the radius supplied by the xml is already the inner radius and the Y half-length instead of the Z half-length needs to be used, Z is just the thickness of the modules... Thankfully this was only used for the event display, the placement of the modules seems to be correct :)
BEGINRELEASENOTES
ENDRELEASENOTES
before: check issue above
after:
