Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure better internal consistency in ALLEGRO ECAL xml #357

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Ensure better internal consistency in ALLEGRO ECAL xml #357

merged 2 commits into from
Jul 22, 2024

Conversation

giovannimarchiori
Copy link
Contributor

@giovannimarchiori giovannimarchiori commented Jul 19, 2024 •
edited by BrieucF
Loading

BEGINRELEASENOTES

  • [ALLEGRO_o1_v03 ECAL barrel] Get number of modules passed to readout from constant defined before in xml
    ENDRELEASENOTES

@giovannimarchiori
Copy link
Contributor Author

Please note that the failures in the tests in the nightlies are not related to these changes

@giovannimarchiori
Copy link
Contributor Author

just rebased

@BrieucF BrieucF merged commit 8de9dc2 into key4hep:main Jul 22, 2024
4 of 6 checks passed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20240719 branch July 30, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrieucF BrieucF BrieucF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannimarchiori @BrieucF