addExtensionsToHCalAllegro #350
Conversation
|
Tagging @faltovaj , @giovannimarchiori and @BrieucF to have a look at the proposed changes |
- will work when the following PRs are merged HEP-FCC/k4RecCalorimeter#91 key4hep/k4geo#350
FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/HCalEndcaps_ThreeParts_TileCal.xml
Outdated
Show resolved
Hide resolved
|
Can you resolve the conflicts so that we can trigger the tests? |
|
Thanks @BrieucF , the conflicts should be fixed now. |
mmlynari
force-pushed
the
addExtensionsToHCalAllegro_4July2024
branch
from
b1720c6 to
bec9aa1
Compare
|
Hello @BrieucF , I updated the barrel xml file to have v02, as the version test was failing due to this. I also updated my branch with the recent PRs and updated the Allegro v03 xml file to include v02 of hcal xmls. |
|
Hello @mmlynari , you need to rebase your branch to pickup some recent PRs that introduced some fixes to remove compiler warnings (that are being treated as errors recently and are making the tests fail) Cheers, Giovanni |
mmlynari
force-pushed
the
addExtensionsToHCalAllegro_4July2024
branch
from
8dfec09 to
495d8c6
Compare
|
Hello @BrieucF , thank you. It's done now |
|
hi @andresailer, |
andresailer
force-pushed
the
addExtensionsToHCalAllegro_4July2024
branch
from
8e77548 to
7ce79d6
Compare
BEGINRELEASENOTES
added new HCalEndcaps_ThreeParts_TileCal_v02.xml: migrated to use FCCSWGridPhiTheta_k4geo; fixed radial dimensions, so the outer radius of all three parts is the same; renamed nModules to nsegments for number of layers in the second cylinder; uses geometry CaloThreePartsEndcap_o1_v02
added new HCalBarrel_TileCal_v02.xml which uses geometry HCalTileBarrel_o1_v01
updated ALLEGRO_o1_v03.xml to include HCalBarrel_TileCal_v02.xml and HCalEndcaps_ThreeParts_TileCal_v02.xml
added new HCalThreePartsEndcap_o1_v02_geo.cpp: added extension to store the radii of each radial layer as well as dimensions of cells. These will be used by the CellPositionsHCalPhiThetaSegTool to calculate the radii of each layer. Improved code readability and variables naming
updated HCalTileBarrel_o1_v01_geo.cpp: added extension to store the radii of each radial layer as well as dimensions of cells. These will be used by the CellPositionsHCalPhiThetaSegTool to calculate the radii of each layer. Improved code readability and variables naming
ENDRELEASENOTES