Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALLEGRO_o1_v03: VTX and drift chamber from IDEA, add magnetic fields #339

Merged
merged 4 commits into from
Jun 6, 2024
Merged

ALLEGRO_o1_v03: VTX and drift chamber from IDEA, add magnetic fields #339

merged 4 commits into from
Jun 6, 2024

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Jun 6, 2024 •
edited
Loading

BEGINRELEASENOTES

  • [FCCee-ALLEGRO_o1_v03] Vertex detector and drift chamber updated to the last IDEA version
  • [FCCee-ALLEGRO_o1_v03] Added solenoidal and MDI magnetic fields
  • [FCCee-ALLEGRO_o1_v03] Removed ALLEGRO_o1_v03_ecalonly.xml and ALLEGRO_o1_v03_trackeronly.xml to ease maintenance (they can be obtained by commenting out sub-detectors)

ENDRELEASENOTES

@BrieucF
Copy link
Contributor Author

BrieucF commented Jun 6, 2024 •
edited
Loading

The stable release test is failing due to a missing driver (DriftChamber_o1_v02).

@giovannimarchiori
Copy link
Contributor

Hi @BrieucF , this looks very good to me. I only have a tiny doubt but I think that in practice it would have essentially no impact on the simulation

giovannimarchiori
giovannimarchiori approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@giovannimarchiori giovannimarchiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge to me!

@BrieucF BrieucF merged commit 45baf19 into key4hep:main Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannimarchiori giovannimarchiori giovannimarchiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrieucF @giovannimarchiori